[VarDumper] Sfdump JS ns and VarCloner replacing Ext+PhpCloner #12145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This surfaced while writting the doc for the component: I also merged ExtCloner and PhpCloner into a new VarCloner class, that dynamically chooses the best available implementation. |
|
👍 for avoiding to make the user choose the implementation |
fabpot
added a commit
that referenced
this pull request
Oct 7, 2014
…class parameters (nicolas-grekas) This PR was merged into the 2.6-dev branch. Discussion ---------- [Framework+SecurityBundle] remove recently introduced *.class parameters | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is just a cleanup that removes `*.class` parameters introduced in the master branch (and not in the 2.5 one). #12145 also removes the remaining params for the Debug/TwigBundle Commits ------- 56ae544 [Framework+SecurityBundle] remove recently introduced *.class parameters
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 7, 2014
…Cloner (nicolas-grekas) This PR was merged into the 2.6-dev branch. Discussion ---------- [VarDumper] Sfdump JS ns and VarCloner replacing Ext+PhpCloner | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12140 | License | MIT | Doc PR | - As VarDumper is independant of the WDT, this patch creates a new JavaScript namespace used for HTML dumps. Commits ------- da96ad8 [VarDumper] Sfdump JS ns and VarCloner replacing Ext+PhpCloner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As VarDumper is independant of the WDT, this patch creates a new JavaScript namespace used for HTML dumps.