[Console] Adding a deprecation note about DialogHelper #12737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rodrigobb
commented
Nov 29, 2014
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #12704 |
| License | MIT |
| Doc PR | - |
| @@ -28,6 +28,12 @@ class DialogHelper extends InputAwareHelper | |||
| private static $shell; | |||
| private static $stty; | |||
|
|
|||
| function __construct() | |||
| { | |||
| trigger_error( 'DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead.', E_USER_DEPRECATED ); | |||
There was a problem hiding this comment.
please remove the last space before the parenthese
|
👍 but the extra space |
9df998c to
cbddc8d
Compare
|
Thank you @rodrigobb. |
| @@ -28,6 +28,12 @@ class DialogHelper extends InputAwareHelper | |||
| private static $shell; | |||
| private static $stty; | |||
|
|
|||
| public function __construct() | |||
| { | |||
| trigger_error('DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
Is it necessary to create constructor? Should be sufficient to add this after the class namespace.
There was a problem hiding this comment.
The stack trace is more precise when done in the constructor (I think).
There was a problem hiding this comment.
Hm, could be. I just think we should do this consistently in all classes.
There was a problem hiding this comment.
Not sure this really matters. And having only one notice instead of one per instance is good
There was a problem hiding this comment.
@nicolas-grekas Right.
@rodrigobb Can you move the line to the beginning of the file? Just after the namespace declaration.
There was a problem hiding this comment.
I've done a commit and push but as the PR is closed it doesn't appear here. How should I do it?
fabpot
pushed a commit
that referenced
this pull request
Nov 30, 2014
fabpot
added a commit
that referenced
this pull request
Nov 30, 2014
This PR was squashed before being merged into the 2.7 branch (closes #12759). Discussion ---------- Append to PR #12737 referring Ticket #12704 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12704 | License | MIT | Doc PR | - Commits ------- b57ce38 Append to PR #12737 referring Ticket #12704
fabpot
added a commit
that referenced
this pull request
Nov 30, 2014
…l constructor in DialogHelper.php on line 37 (driskell) This PR was merged into the 2.7 branch. Discussion ---------- [Console] [DialogHelper] Fix PHP Fatal error: Cannot call constructor in DialogHelper.php on line 37 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Since yesterday our composer builds have been failing due to an error originating from Symfony/console. We've also been seeing duplicated deprecation warnings: ``` PHP Deprecated: \Symfony\Component\Console\Helper\DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead. in vendor/symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 14 PHP Deprecated: DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead. in vendor/symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 35 PHP Fatal error: Cannot call constructor in vendor/symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 37 ``` It looks like this was introduced in PR #12737. Then #12759 was raised to change the warning to the header to only print a single warning. But rather than #12759 having #12737 as a parent and reverting it - it's parent is from before #12737 was merged. So there's now a situation of both PR having being merged - one adding deprecation warning to file header, and one adding deprecation to construct() (and also causing fatal error.) This PR fixes the issue by reverting the breaking parent::construct() added by #12737 so essentially only #12759 is active, which adds a single deprecation warning, and does not break the code. NB: This is the test failure for the Console component - test fails since #12737. This patch fixes this and passes all tests for the Console component. ``` $ phpunit src/Symfony/Component/Console PHP Fatal error: Cannot call constructor in src/Symfony/Component/Console/Helper/DialogHelper.php on line 37 ``` Jason Commits ------- ada9a58 Fix PHP Fatal error: Cannot call constructor in symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 37
|
note to maintainers: we need to be careful when merging deprecation messages, to be sure that our BC layers don't trigger them, but only the usage of the BC layers. So here, the instantiation should not trigger it, given the Application class triggers the instantiation |
|
To add to @stof - investigating some issues I'm having with composer and third party command integrators. It seems that Symfony/Console/Application actually instantiates these classes when initialising Helpers. (For example, it creates instances of DialogHelper and TableHelper) It does not seem intentional to me that Symfony should be raising Deprecation messages when you instantiate or use a non-deprecated object like Symfony/Console/Application |
fabpot
added a commit
that referenced
this pull request
Dec 2, 2014
* 2.7: (65 commits) Configure firewall's kernel exception listener with configured entry point or a default entry point PSR-2 fixes [DependencyInjection] make paths relative to __DIR__ in the generated container [FrameworkBundle][Router Cmd] use debug namespace. [FrameworkBundle] Update deprecated service call Fix PHP Fatal error: Cannot call constructor in symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 37 Removed a dev annotation from a version constraint Fixed the syntax of a composer.json file Fixed the symfony/config version constraint Tweaked the password-compat version constraint Docblock fixes Append to PR #12737 referring Ticket #12704 Issue #12658 Add a deprecation note about Translator's setFallbackLocale... Issue #12606 Adding warning logs about the deprecation of [...]/Tests/FormIntegration... Hackday deprecated 12621 Added deprecation log for validate and validateValue on ExecutionContext... [Console] [Hackday] [2.7] Add a deprecation note about ProgressHelper [Hackday][2.7] Add a deprecation note about MetadataInterface's accept() method [Validator] Added a deprecation note about setPropertyAccessor #12698 [Locale] Adding a deprecation note about the Locale component ...
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
* 2.7: (65 commits) Configure firewall's kernel exception listener with configured entry point or a default entry point PSR-2 fixes [DependencyInjection] make paths relative to __DIR__ in the generated container [FrameworkBundle][Router Cmd] use debug namespace. [FrameworkBundle] Update deprecated service call Fix PHP Fatal error: Cannot call constructor in symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 37 Removed a dev annotation from a version constraint Fixed the syntax of a composer.json file Fixed the symfony/config version constraint Tweaked the password-compat version constraint Docblock fixes Append to PR symfony#12737 referring Ticket symfony#12704 Issue symfony#12658 Add a deprecation note about Translator's setFallbackLocale... Issue symfony#12606 Adding warning logs about the deprecation of [...]/Tests/FormIntegration... Hackday deprecated 12621 Added deprecation log for validate and validateValue on ExecutionContext... [Console] [Hackday] [2.7] Add a deprecation note about ProgressHelper [Hackday][2.7] Add a deprecation note about MetadataInterface's accept() method [Validator] Added a deprecation note about setPropertyAccessor symfony#12698 [Locale] Adding a deprecation note about the Locale component ...
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Dec 15, 2020
* 2.7: (65 commits) Configure firewall's kernel exception listener with configured entry point or a default entry point PSR-2 fixes [DependencyInjection] make paths relative to __DIR__ in the generated container [FrameworkBundle][Router Cmd] use debug namespace. [FrameworkBundle] Update deprecated service call Fix PHP Fatal error: Cannot call constructor in symfony/console/Symfony/Component/Console/Helper/DialogHelper.php on line 37 Removed a dev annotation from a version constraint Fixed the syntax of a composer.json file Fixed the symfony/config version constraint Tweaked the password-compat version constraint Docblock fixes Append to PR symfony#12737 referring Ticket symfony#12704 Issue symfony#12658 Add a deprecation note about Translator's setFallbackLocale... Issue symfony#12606 Adding warning logs about the deprecation of [...]/Tests/FormIntegration... Hackday deprecated 12621 Added deprecation log for validate and validateValue on ExecutionContext... [Console] [Hackday] [2.7] Add a deprecation note about ProgressHelper [Hackday][2.7] Add a deprecation note about MetadataInterface's accept() method [Validator] Added a deprecation note about setPropertyAccessor symfony#12698 [Locale] Adding a deprecation note about the Locale component ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.