[Console] Adding a deprecation note about DialogHelper #12737
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,14 +20,20 @@ | |
| * @author Fabien Potencier <[email protected]> | ||
| * | ||
| * @deprecated Deprecated since version 2.5, to be removed in 3.0. | ||
| * Use {@link \Symfony\Component\Console\Helper\QuestionHelper} instead. | ||
| */ | ||
| class DialogHelper extends InputAwareHelper | ||
| { | ||
| private $inputStream; | ||
| private static $shell; | ||
| private static $stty; | ||
|
|
||
| public function __construct() | ||
| { | ||
| trigger_error('DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead.', E_USER_DEPRECATED); | ||
|
|
||
| parent::__construct(); | ||
|
There was a problem hiding this comment. This is throwing a PHP Fatal Error as there is no parent constructor. There was a problem hiding this comment. I've modified my code, but I don't know how to commit now. Could you please help me? There was a problem hiding this comment. @rodrigobb You will have to create a new pull request as this one has already been merged. There was a problem hiding this comment. I've created a new PR #12759. Could someone check everything is ok now? There was a problem hiding this comment. The new PR doesn't appear to remove the constructor call that causes the fatal error There was a problem hiding this comment. OK it does :-) GitHub doing odd things with the diff. |
||
| } | ||
| /** | ||
| * Asks the user to select a value. | ||
| * | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to create constructor? Should be sufficient to add this after the class namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stack trace is more precise when done in the constructor (I think).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, could be. I just think we should do this consistently in all classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this really matters. And having only one notice instead of one per instance is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolas-grekas Right.
@rodrigobb Can you move the line to the beginning of the file? Just after the namespace declaration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a commit and push but as the PR is closed it doesn't appear here. How should I do it?