Add LegacyPdoSessionHandler class #13068
Conversation
The changes made to the PdoSessionHandler in 2.6 introduced a backwards-compatability break for users upgrading from 2.5. This update introduces a LegacyPdoSessionHandler class that uses the old service's functionality. Users who cannot make schema updates or do not want to lose sessions can use LegacyPdoSessionHandler until 3.0.
|
Hmm, shouldn't this be added to 2.6 as it fixes a BC break? |
|
Sure thing; it should be merged into 2.6. |
|
@fabpot, do you need me to do anything else or are you able to merge this PR into 2.6 too? |
|
Thank you @jeremylivingston. |
|
@jeremylivingston Merged now in 2.6 and 2.7. Can you submit an additional PR on 2.7 where we trigger a deprecated warning? |
|
@fabpot, sure. I have a |
|
Yes, as of 2.7, we should also trigger a PHP error. You can see many examples in the 2.7 branch, just have a look for |
|
@fabpot Sure thing. I will take a look. Sorry I misunderstood when you originally asked. |
|
@jeremylivingston No worries, I wasn't very clear in my comment. |
…mylivingston) This PR was merged into the 2.7 branch. Discussion ---------- Add deprecation warning to LegacyPdoSessionHandler | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A LegacyPdoSessionHandler has been deprecated in favor of PdoSessionHandler. Trigger an E_USER_DEPRECATED error when the deprecated class is used. Addresses @fabpot's comment on [#13068](#13068 (comment)). Commits ------- 3b9c073 Add deprecation warning to LegacyPdoSessionHandler
…mylivingston) This PR was merged into the 2.7 branch. Discussion ---------- Add deprecation warning to LegacyPdoSessionHandler | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A LegacyPdoSessionHandler has been deprecated in favor of PdoSessionHandler. Trigger an E_USER_DEPRECATED error when the deprecated class is used. Addresses @fabpot's comment on [#13068](symfony/symfony#13068 (comment)). Commits ------- 3b9c073 Add deprecation warning to LegacyPdoSessionHandler
Fix for #12994 on the 2.7 branch.
The changes made to the PdoSessionHandler in 2.6 introduced a
backwards-compatability break for users upgrading from 2.5. This update
introduces a LegacyPdoSessionHandler class that uses the old service's
functionality.
Users who cannot make schema updates or do not want to lose sessions can
use LegacyPdoSessionHandler until 3.0.