-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
let Travis builds fail when PHP 7 jobs fail #14115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xabbuh
commented
Mar 30, 2015
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | |
License | MIT |
Doc PR |
👎 nightly is not stable yet. why would we depend on it? |
Now, that we are at a point where our tests are passing on PHP 7, I think it's a good idea (especially because it isn't stable yet) for two reasons:
I believe that we wouldn't notice failures (regardless of the reason for it) really soon if we were suppose to check the build log of passed Travis builds. |
If it does fail too often because of temporarily broken php I'm ok with it. |
I also think it's too early to enforce this. |
Hum, we're now 3 days after, the time has come :) |
Actually, I was thinking about closing this as we are actually not yet where I thought when opening this PR (see #14086). :) |
@nicolas-grekas you could start debugging the Debug and VarDumper tests on PHP7 then 😄 |
I was just looking at them :) |
@xabbuh can you please rebase? We're almost ready to merge this one! |
963e520
to
ecc3df5
Compare
Ready to go. |
Thank you @xabbuh. |
This PR was merged into the 2.3 branch. Discussion ---------- let Travis builds fail when PHP 7 jobs fail | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- ecc3df5 let Travis builds fail when PHP 7 jobs fail