Thanks to visit codestin.com
Credit goes to github.com

Skip to content

let Travis builds fail when PHP 7 jobs fail #14115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 30, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@Tobion
Copy link
Contributor

Tobion commented Mar 30, 2015

👎 nightly is not stable yet. why would we depend on it?

@xabbuh
Copy link
Member Author

xabbuh commented Mar 30, 2015

Now, that we are at a point where our tests are passing on PHP 7, I think it's a good idea (especially because it isn't stable yet) for two reasons:

  1. We notice very early when our code breaks in case that some PHP behaviour changes intentionally. Hence, we can react fast and adapt the Symfony code to be compatible again (we can decide to allow failures again if we notice that it will take us some time to make the needed changes).
  2. If the code breaks because of a regression in PHP itself, we will be able to report them as soon as possible to the PHP devs (and again, we could revert this change again if fixing PHP would take some time).

I believe that we wouldn't notice failures (regardless of the reason for it) really soon if we were suppose to check the build log of passed Travis builds.

@Tobion
Copy link
Contributor

Tobion commented Mar 30, 2015

If it does fail too often because of temporarily broken php I'm ok with it.

@nicolas-grekas
Copy link
Member

I also think it's too early to enforce this.

@nicolas-grekas
Copy link
Member

Hum, we're now 3 days after, the time has come :)
Rethinking about it, I'd be 👍 for this reason: ZF 2.4 already communicates on being PHP7 compatible. That means the guy from Zend will ensure that they do not break anything anymore.
We need to be able to communicate on 2.7 being PHP7 ready.

@xabbuh
Copy link
Member Author

xabbuh commented Apr 3, 2015

Actually, I was thinking about closing this as we are actually not yet where I thought when opening this PR (see #14086). :)

@stof
Copy link
Member

stof commented Apr 3, 2015

@nicolas-grekas you could start debugging the Debug and VarDumper tests on PHP7 then 😄

@nicolas-grekas
Copy link
Member

I was just looking at them :)

@nicolas-grekas
Copy link
Member

@xabbuh can you please rebase? We're almost ready to merge this one!

@xabbuh xabbuh force-pushed the claim-php-7-compatibility branch from 963e520 to ecc3df5 Compare July 28, 2015 17:37
@xabbuh
Copy link
Member Author

xabbuh commented Jul 28, 2015

Ready to go.

@fabpot
Copy link
Member

fabpot commented Aug 5, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit ecc3df5 into symfony:2.3 Aug 5, 2015
fabpot added a commit that referenced this pull request Aug 5, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

let Travis builds fail when PHP 7 jobs fail

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

ecc3df5 let Travis builds fail when PHP 7 jobs fail
@xabbuh xabbuh deleted the claim-php-7-compatibility branch August 5, 2015 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants