Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix currently broken tests #14205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix currently broken tests #14205

wants to merge 2 commits into from

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Apr 3, 2015

Glitch from 8f72338

@mpdude
Copy link
Contributor Author

mpdude commented Apr 3, 2015

Maybe I'm wrong here - can one rely on the first argument being the command?

If so, \Symfony\Component\Console\Tester\CommandTester::execute does not seem to guarantee this.

@wouterj
Copy link
Member

wouterj commented Apr 3, 2015

I think this is going to be fixed by #14197 already

@mpdude
Copy link
Contributor Author

mpdude commented Apr 3, 2015

Not sure if #14197 does the right thing (tm)?

@aitboudad
Copy link
Contributor

@mpdude FYI $input->getArgument('command') return the cmd name and doesn't allow to know if the user uses the alias or name to execute this command

@mpdude
Copy link
Contributor Author

mpdude commented Apr 4, 2015

So, trying to fix it by making sure the CommandTester adds the command name as first argument.

@fabpot
Copy link
Member

fabpot commented Apr 4, 2015

👍

@mpdude
Copy link
Contributor Author

mpdude commented Apr 4, 2015

If the first argument has such a special meaning and can (always?) be expected to contain the (unparsed?) command name, maybe that would be worth a doc note somewhere? (DocBlock?)

@aitboudad
Copy link
Contributor

now it's ok 👍

@mpdude
Copy link
Contributor Author

mpdude commented Apr 4, 2015

Please merge so folks with open PRs can rebase and get their tests green again :-)

@xabbuh
Copy link
Member

xabbuh commented Apr 4, 2015

👍

@mpdude
Copy link
Contributor Author

mpdude commented Apr 4, 2015

Can anyone see why some of the Travis builds still fail as before?

@fabpot
Copy link
Member

fabpot commented Apr 4, 2015

Thank you @mpdude.

@fabpot fabpot closed this in c29f779 Apr 4, 2015
@mpdude mpdude deleted the fix-tests branch April 4, 2015 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants