-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Fix currently broken tests #14205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix currently broken tests #14205
Conversation
Maybe I'm wrong here - can one rely on the first argument being the command? If so, \Symfony\Component\Console\Tester\CommandTester::execute does not seem to guarantee this. |
I think this is going to be fixed by #14197 already |
Not sure if #14197 does the right thing (tm)? |
@mpdude FYI $input->getArgument('command') return the cmd name and doesn't allow to know if the user uses the alias or name to execute this command |
So, trying to fix it by making sure the |
👍 |
If the first argument has such a special meaning and can (always?) be expected to contain the (unparsed?) command name, maybe that would be worth a doc note somewhere? (DocBlock?) |
now it's ok 👍 |
Please merge so folks with open PRs can rebase and get their tests green again :-) |
👍 |
Can anyone see why some of the Travis builds still fail as before? |
Thank you @mpdude. |
Glitch from 8f72338