-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form] Fix BC break introduced in #14050 #14223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,12 +11,14 @@ | |
|
||
namespace Symfony\Component\Form\ChoiceList\View; | ||
|
||
use Symfony\Component\Form\Extension\Core\View\ChoiceView as LegacyChoiceView; | ||
|
||
/** | ||
* Represents a choice in templates. | ||
* | ||
* @author Bernhard Schussek <[email protected]> | ||
*/ | ||
class ChoiceView | ||
class ChoiceView extends LegacyChoiceView | ||
{ | ||
/** | ||
* The label displayed to humans. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,18 +11,37 @@ | |
|
||
namespace Symfony\Component\Form\Extension\Core\View; | ||
|
||
use Symfony\Component\Form\ChoiceList\View\ChoiceView as BaseChoiceView; | ||
|
||
/** | ||
* Represents a choice in templates. | ||
* | ||
* @author Bernhard Schussek <[email protected]> | ||
* | ||
* @deprecated Deprecated since Symfony 2.7, to be removed in Symfony 3.0. | ||
* Use {@link BaseChoiceView} instead. | ||
* Use {@link \Symfony\Component\Form\ChoiceList\View\ChoiceView} instead. | ||
*/ | ||
class ChoiceView extends BaseChoiceView | ||
class ChoiceView | ||
{ | ||
/** | ||
* The original choice value. | ||
* | ||
* @var mixed | ||
*/ | ||
public $data; | ||
|
||
/** | ||
* The view representation of the choice. | ||
* | ||
* @var string | ||
*/ | ||
public $value; | ||
|
||
/** | ||
* The label displayed to humans. | ||
* | ||
* @var string | ||
*/ | ||
public $label; | ||
|
||
/** | ||
* Creates a new ChoiceView. | ||
* | ||
|
@@ -32,7 +51,9 @@ class ChoiceView extends BaseChoiceView | |
*/ | ||
public function __construct($data, $value, $label) | ||
{ | ||
parent::__construct($label, $value, $data); | ||
$this->data = $data; | ||
$this->value = $value; | ||
$this->label = $label; | ||
|
||
trigger_error('The '.__CLASS__.' class is deprecated since version 2.7 and will be removed in 3.0. Use Symfony\Component\Form\ChoiceList\View\ChoiceView instead.', E_USER_DEPRECATED); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be triggered only when
get_class($this) === __CLASS__
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stof no it must not because the new class does not call the parent class at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but for people extending the choice view to provide their own implementation, this would still be useful indeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tobion they would get the deprecation thrown by the DebugClassLoader already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fixing this issue in #14201.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see https://github.com/symfony/symfony/pull/14201/files#diff-9e5af2e8b536ca5236670f58d24ba1d9R59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we worked on the same at the same time :) See #14258 for an alternative