[Form] Swap new ChoiceView constructor arguments to ease migrating from the deprecated one #14887
Conversation
nicolas-grekas
commented
Jun 5, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #14193 |
| License | MIT |
| Doc PR | - |
|
Since 2.7.0 is really a stabilization release (like all .0 releases) and 2.7.1 is about to be tagged, having this in 2.7.1 is the only window we have to get this fixed. |
882ee0d to
1eb90fe
Compare
|
👍 ping @symfony/deciders |
|
I am not sure if that is a good idea. Yes, it's not consistent, but do we really want people have to change their apps again if they already adapted the new |
| @@ -23,7 +23,7 @@ | |||
| "symfony/phpunit-bridge": "~2.7", | |||
| "symfony/asset": "~2.7", | |||
| "symfony/finder": "~2.3", | |||
| "symfony/form": "~2.7", | |||
| "symfony/form": "~2.7,>=2.7.1", | |||
There was a problem hiding this comment.
This would be the first use of the caret operator isn't it?
We'd rather stick with what we do elsewhere here, and open an other PR for moving everything to the caret operator (and discuss there if it's too early or not)
|
This should be documented as a BC break between 2.7.0 and 2.7.1 though |
1eb90fe to
a0df596
Compare
|
UPGRADE-2.7 updated. If someone has a better wording idea, I'm open to suggestions. |
…om the deprecated one
a0df596 to
909d2b9
Compare
|
👍 |
|
Thank you @nicolas-grekas. |
…igrating from the deprecated one (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Form] Swap new ChoiceView constructor arguments to ease migrating from the deprecated one | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14193 | License | MIT | Doc PR | - Commits ------- 909d2b9 [Form] Swap new ChoiceView constructor arguments to ease migrating from the deprecated one