-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Added the right revision date for status code registry #15796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the right revision date for status code registry #15796
Conversation
Indeed, we can update the list of official HTTP status codes, but just changing the date is not enough. For instance, the 418 status code has been removed (yep, no more teapot). |
ok, working on it |
@fabpot done, I am just not sur about the |
👍 |
417 => 'Expectation Failed', | ||
418 => 'I\'m a teapot', // RFC2324 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can't be done in 2.3. Removing the key is a BC break in case someone accesses it in the public array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see that as IMO you should not access it directly. So I should do it in master right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @stof
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BC break of HTTP Code 418 fixed with #16585
Merging it in 2.8 |
Thank you @dupuchba. |
…dupuchba) This PR was submitted for the 2.3 branch but it was merged into the 2.8 branch instead (closes #15796). Discussion ---------- Added the right revision date for status code registry | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT It's just a doc-fix. Last updated status codes were not the right ones, not very useful though but you can merge it :-). http://www.iana.org/assignments/http-status-codes/ Commits ------- 07d08c4 Added the right revision date for status code registry
It's just a doc-fix.
Last updated status codes were not the right ones, not very useful though but you can merge it :-).
http://www.iana.org/assignments/http-status-codes/