Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Yaml] more fixes to changelog and upgrade files #16662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 25, 2015

Q A
Fixed tickets #16433, #16654
License MIT

@stof
Copy link
Member

stof commented Nov 25, 2015

👍

* Deprecated non-escaped \ in double-quoted strings when parsing Yaml
("Foo\Var" is not valid whereas "Foo\\Var" is)
* Deprecated non-escaped `\` in double-quoted strings when parsing Yaml
(`Foo\Var` is not valid whereas `Foo\\Var` is)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not super clear to me. Maybe a before and after? I believe it would be:

Before:

class: "Foo\Var"

After

class: "Foo\\Var"

Or, you could use single quotes and just have Foo\Var, right? Can you have no quotes and just Foo\Var?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, escaping the backslash is only needed when using double quotes. Escape sequences are only available in double-quoted strings:

Note that escape sequences are only interpreted in double-quoted scalars. In all other scalar styles, the “\” character has no special meaning and non-printable characters are not available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the note. How about this (FYI: I'm missing a closing tick after the code-blocks, so it'll render here)

When surrounding strings with double-quotes, you must now escape `\` characters. Not escaping
those characters (when surrounded by double-quotes) is deprecated.

Before:

```yml
class: "Foo\Var"
``

After:

```yml
class: "Foo\\Var"
``

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean. Makes sense to me.

@fabpot
Copy link
Member

fabpot commented Nov 28, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit 273ed25 into symfony:2.8 Nov 28, 2015
fabpot added a commit that referenced this pull request Nov 28, 2015
…ian Flothmann)

This PR was merged into the 2.8 branch.

Discussion
----------

[Yaml] more fixes to changelog and upgrade files

| Q             | A
| ------------- | ---
| Fixed tickets | #16433, #16654
| License       | MIT

Commits
-------

273ed25 [Yaml] more fixes to changelog and upgrade files
@xabbuh xabbuh deleted the pr-16433-upgrade branch November 28, 2015 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants