-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Yaml] more fixes to changelog and upgrade files #16662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xabbuh
commented
Nov 25, 2015
Q | A |
---|---|
Fixed tickets | #16433, #16654 |
License | MIT |
👍 |
* Deprecated non-escaped \ in double-quoted strings when parsing Yaml | ||
("Foo\Var" is not valid whereas "Foo\\Var" is) | ||
* Deprecated non-escaped `\` in double-quoted strings when parsing Yaml | ||
(`Foo\Var` is not valid whereas `Foo\\Var` is) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not super clear to me. Maybe a before and after? I believe it would be:
Before:
class: "Foo\Var"
After
class: "Foo\\Var"
Or, you could use single quotes and just have Foo\Var
, right? Can you have no quotes and just Foo\Var
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, escaping the backslash is only needed when using double quotes. Escape sequences are only available in double-quoted strings:
Note that escape sequences are only interpreted in double-quoted scalars. In all other scalar styles, the “\” character has no special meaning and non-printable characters are not available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the note. How about this (FYI: I'm missing a closing tick after the code-blocks, so it'll render here)
When surrounding strings with double-quotes, you must now escape `\` characters. Not escaping
those characters (when surrounded by double-quotes) is deprecated.
Before:
```yml
class: "Foo\Var"
``
After:
```yml
class: "Foo\\Var"
``
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. Makes sense to me.
9a6e14e
to
6537b6f
Compare
6537b6f
to
273ed25
Compare
Thank you @xabbuh. |