[Form] Removed useless code #16725
Merged
[Form] Removed useless code #16725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
webmozart
commented
Nov 28, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
👍 |
| 'choices' => array(), | ||
| 'choices_as_values' => null, // to be deprecated in 3.1 | ||
| 'choices_as_values' => true, // to be deprecated in 3.1 |
There was a problem hiding this comment.
this was done in order to be able to distinguish between somebody setting the option to true and somebody not touching the option at all. If somebody sets it to true manually, it should trigger a deprecation because he would get an exception when we remove the option.
There was a problem hiding this comment.
You're right, updated
5c0f5b0 to
8add405
Compare
|
Thank you @webmozart. |
Tobion
added a commit
that referenced
this pull request
Nov 28, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- [Form] Removed useless code | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 8add405 [Form] Removed useless code
|
The first test failure should be fixed when merged and the second one seems unrelated. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 29, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [Bridge/Doctrine+Ldap] Fix tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Using "choice_list" is deprecated and thus can't work with 3.0 deps loaded. Test upgrades backported from #16725 @csarrazi : the Ldap tests now require the ldap extension. Annotations added. Commits ------- 4819a70 [Bridge/Doctrine+Ldap] Fix tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.