[Security] skip bcrypt tests on incompatible platforms #17073
Conversation
|
This should make tests on Appveyor pass again. |
|
👍 |
Not all PHP versions before 5.3.7 have backported fixes that make it possible to use `password_hash()` function. Therefore, we have to skip tests on not supported platforms.
|
I really prefer the annotation, we don't care about patched php versions, this is a test suite, not a framework :-) |
|
Well, I think it's good to be able to run the tests on PHP 5.3 on Travis when we claim compatibility with that PHP version. |
|
👍 This allows to run the tests on Travis's lowest test jobs (as travis has a compatible PHP patch), but makes Appveyor pass as well. |
|
Travis runs a higher version than 5.3.7 isn't it? |
|
@nicolas-grekas We define |
|
@xabbuh yep it is: the travis matrix is big enough, lowest php versions are run on appveyor |
|
@nicolas-grekas So we should remove the variable from the Travis config? Anyway, I would keep the test this way as the tests would then be executed on Appveyor if they ever used backported fixes in their PHP versions. |
|
As you can read in the travis file, the var is actually used for testing the process component with --enable-sigchild, so we should keep it |
|
@xabbuh ok to revert to the annotated version? Adding this method + conditional branching adds cyclomatic complexity for a case that our test matrix never reaches and is not required to reach (because we don't test the native implementation but our php wrapper, which wouldn't be better covered by going to this corner case) |
|
@nicolas-grekas I don't have too hard feelings about this. So I reverted to use the |
|
👍 |
|
Everything's finally green again. |
|
Thank you @xabbuh. |
…Christian Flothmann, xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Security] skip bcrypt tests on incompatible platforms | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17055 | License | MIT | Doc PR | Not all PHP versions before 5.3.7 have backported fixes that make it possible to use `password_hash()` function. Therefore, we have to skip tests on not supported platforms. Commits ------- 2a6fa7b use requires annotation 65eb188 skip bcrypt tests on incompatible platforms
This PR was merged into the 2.7 branch. Discussion ---------- [Security] Run tests on all PHP versions Symfony 2.7 supports PHP >= 5.3.9. Since #17073 was merged to 2.7 now, we need to remove the checks for 5.3.7 again. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 4bec980 [Security] Run tests on all PHP versions
Not all PHP versions before 5.3.7 have backported fixes that make it
possible to use
password_hash()function. Therefore, we have to skiptests on not supported platforms.