[ClassLoader] Use symfony/polyfill-apcu #17358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
586b9d5 to
ced974c
Compare
|
👍 |
|
Shouldn't tests be updated as well? |
|
@jakzal this test class does not exist in 2.3, but yes you're right |
| @@ -67,7 +67,7 @@ class ApcClassLoader | |||
| */ | |||
| public function __construct($prefix, $decorated) | |||
| { | |||
| if (!extension_loaded('apc')) { | |||
| if (!ini_get('apc.enabled') || ('cli' === PHP_SAPI && !ini_get('apc.enable_cli'))) { | |||
There was a problem hiding this comment.
this could be a potential bc break for people who installed apc but didn't enable it. And I don't feel like it's the classes responsibility to check if apc is enabled. it should only make sure the methods can be called, i.e how it was before.
There was a problem hiding this comment.
updated using if (!function_exists('apcu_fetch')) {
| @@ -67,7 +67,7 @@ class ApcClassLoader | |||
| */ | |||
| public function __construct($prefix, $decorated) | |||
| { | |||
| if (!extension_loaded('apc')) { | |||
| if (!function_exists('apcu_fetch')) { | |||
| throw new \RuntimeException('Unable to use ApcClassLoader as APC is not enabled.'); | |||
There was a problem hiding this comment.
IMO "enabled" should be replaced by "installed"
There was a problem hiding this comment.
let's go for "installed"
|
Thank you @nicolas-grekas. |
Tobion
added a commit
that referenced
this pull request
Jan 14, 2016
This PR was merged into the 2.3 branch. Discussion ---------- [ClassLoader] Use symfony/polyfill-apcu | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fixes APC usage on PHP 7 or when APCu bc-layer is disabled Commits ------- 623595f [ClassLoader] Use symfony/polyfill-apcu
This was referenced Jan 15, 2016
fabpot
added a commit
that referenced
this pull request
Jan 25, 2016
This PR was merged into the 2.3 branch. Discussion ---------- [ClassLoader] Use symfony/polyfill-apcu | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - #17358 updated ApcClassLoader to use polyfill-apcu, but not ApcUniversalClassLoader 2.7 / 2.8 tests are in LegacyApcUniversalClassLoaderTest Commits ------- a0dc399 [ClassLoader] Use symfony/polyfill-apcu
Merged
This was referenced Feb 28, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APC usage on PHP 7 or when APCu bc-layer is disabled