[ClassLoader] Use symfony/polyfill-apcu #17396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additionally
|
| @@ -14,14 +14,14 @@ | |||
| use Symfony\Component\ClassLoader\ApcUniversalClassLoader; | |||
|
|
|||
| /** | |||
| * @requires extension apc | |||
There was a problem hiding this comment.
@nicolas-grekas I think you missed to remove that in https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/ClassLoader/Tests/ApcClassLoaderTest.php#L18 as this will forbid to use this test against apcu without bc layer.
There was a problem hiding this comment.
and its already skipped in setUp anyway.
Because 2.8 did not get merged in 3.0 yet |
29bc90d to
a0dc399
Compare
|
Thank you @gapple. |
fabpot
added a commit
that referenced
this pull request
Jan 25, 2016
This PR was merged into the 2.3 branch. Discussion ---------- [ClassLoader] Use symfony/polyfill-apcu | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - #17358 updated ApcClassLoader to use polyfill-apcu, but not ApcUniversalClassLoader 2.7 / 2.8 tests are in LegacyApcUniversalClassLoaderTest Commits ------- a0dc399 [ClassLoader] Use symfony/polyfill-apcu
fabpot
added a commit
that referenced
this pull request
Jan 25, 2016
This PR was merged into the 3.0 branch. Discussion ---------- remove obsolete apcu polyfill | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As @gapple pointed out in #17396 > APC is PHP <=5.4, so symfony/polyfill-apcu shouldn't be a dependency on 3.0 or master Commits ------- 5bf64ea remove obsolete apcu polyfill
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.7 / 2.8 tests are in LegacyApcUniversalClassLoaderTest