[Serializer] Add PSR-6 adapter #17446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Jan 19, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | todo |
- Add tests
| public function getMetadataFor($value) | ||
| { | ||
| $class = $this->getClass($value); | ||
| // Key cannot contains backslashes according to PSR-6 |
There was a problem hiding this comment.
cannot contains -> cannot contain
|
Please mark unfinished PRs with "[WIP]". |
| */ | ||
|
|
||
| namespace Symfony\Component\Serializer\Mapping\Factory; | ||
| use Psr\Cache\CacheItemPoolInterface; |
63a7431 to
b609714
Compare
|
This PR is now ready to be merged. |
| @@ -44,6 +46,10 @@ public function __construct(LoaderInterface $loader, Cache $cache = null) | |||
| { | |||
| $this->loader = $loader; | |||
| $this->cache = $cache; | |||
|
|
|||
| if (null !== $cache) { | |||
| @trigger_error('Passing a Doctrine Cache instance as 2nd parameter of the "Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactoryInterface" is deprecated. This parameter will be removed in Symfony 4.0. Use the "Symfony\Component\Serializer\Mapping\Factory\CacheMetadataFactory" class instead.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
It seems that you are as tired as I am 😉 The second FQN must be the new one (and BTW you can use sprintf with __CLASS__ / ::class)
|
@dunglas Can you finish this one? |
b609714 to
355f48c
Compare
|
Should be finished now. |
| "doctrine/annotations": "~1.0", | ||
| "doctrine/cache": "~1.0" | ||
| }, | ||
| "suggest": { | ||
| "doctrine/annotations": "For using the annotation mapping. You will also need doctrine/cache.", | ||
| "doctrine/cache": "For using the default cached annotation reader and metadata cache.", | ||
| "symfony/cache": "For using the metadata cache.", |
There was a problem hiding this comment.
On the validator PR, you added "psr/cache-implementation": "For using the metadata cache.", instead. Not that it matters so much, but for consistency, we should do the same everywhere.
|
@fabpot replaced |
|
Thank you @dunglas. |
| { | ||
| $metadata = new ClassMetadata('Symfony\Component\Serializer\Tests\Fixtures\Dummy'); | ||
|
|
||
| $decorated = $this->getMock('Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactoryInterface'); |
fabpot
added a commit
that referenced
this pull request
Jan 27, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Serializer] Use ::class in new tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17446 (comment) | License | MIT | Doc PR | n/a Commits ------- 48e8041 [Serializer] Use ::class in new tests
symfony-splitter
pushed a commit
to symfony/serializer
that referenced
this pull request
Jan 27, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Serializer] Use ::class in new tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#17446 (comment) | License | MIT | Doc PR | n/a Commits ------- 48e8041 [Serializer] Use ::class in new tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.