[FrameworkBundle] Use canBeEnabled() instead of canBeUnset() for consistency#17690
Closed
GuilhemN wants to merge 2 commits into
Closed
[FrameworkBundle] Use canBeEnabled() instead of canBeUnset() for consistency#17690GuilhemN wants to merge 2 commits into
GuilhemN wants to merge 2 commits into
Conversation
Member
|
👍 |
Member
|
To keep BC, I would keep the |
Contributor
Author
|
@fabpot in case someone uses the FrameworkBundle's |
Member
|
@Ener-Getick I know that the BC break would be small, but as it does not cost us anything to not break BC, I prefer to. |
Contributor
Author
Member
|
ok, fair enough, 👍 |
Member
|
Thank you @Ener-Getick. |
Contributor
Author
|
You're welcome :-) And I see one solution to keep ->arrayNode()
->canBeEnabled()
->canBeUnset()
->threatFalseLike(false) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if we should consider this as a bug fix or as a new feature.