-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] Use canBeEnabled() instead of canBeUnset() for consistency #17690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 |
To keep BC, I would keep the |
@fabpot in case someone uses the FrameworkBundle's |
@Ener-Getick I know that the BC break would be small, but as it does not cost us anything to not break BC, I prefer to. |
ok, fair enough, 👍 |
Thank you @Ener-Getick. |
You're welcome :-) And I see one solution to keep ->arrayNode()
->canBeEnabled()
->canBeUnset()
->threatFalseLike(false) |
I'm not sure if we should consider this as a bug fix or as a new feature.