Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpKernel] Fixed a typo in the collect() method of Profiler #18123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

NicolasNSSM
Copy link

Q A
Branch 2.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18088
License MIT
Doc PR

@javiereguiluz
Copy link
Member

@nnussbaum thanks for this contribution! You did it well ... except for one minor thing.

In the table that you fill in for each pull request, in the Branch cell you left the original message: "master for features and deprecations / lowest applicable and maintained version otherwise"

This is in fact a message for you (the person who submitted the pull request). You need to think the best branch on which the pull request should be merged. These are the rules:

  • If it's a new feature, select "master"
  • If it's a bug, select the oldest (but maintained) Symfony branch which suffers that error.

In this case it's a bug and the oldest maintained branch who suffers the issue is 2.3, so you need to put 2.3 as the value of the Branch row in the table. Thanks!

@NicolasNSSM
Copy link
Author

Arf, just saw that... Wont make the mistake again! Thank you :)

@javiereguiluz
Copy link
Member

A note to you from Symfony maintainers:

Thank you for making this contribution to Symfony. As you know, we prepared some simple issues so you could submit real pull requests fixing real issues. However, as there are more people than issues, we'll need to close some repeated pull requests without merging them.

We are not sure about the criteria we'll use to close repeated pull requests (first one wins? randomly selected one wins?). So maybe your pull request is closed without merging it. But please, don't feel bad about that. You did great and you actually contributed to Symfony 🎉 If this pull request doesn't get merged, there will be more opportunities to send new pull requests.

Thank you for being part of the (big and awesome) Symfony Community!

@fabpot fabpot closed this Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants