[Cache] Redis adapter#18172
Merged
Merged
Conversation
Member
nicolas-grekas
commented
Mar 15, 2016
| Q | A |
|---|---|
| Branch | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #17441 |
| License | MIT |
| Doc PR | - |
8899123 to
0d2ecbd
Compare
| */ | ||
| protected function doClear($namespace) | ||
| { | ||
| $this->redis->eval("for _,k in ipairs(redis.call('keys','{$namespace}*')) do redis.call('del',k) end"); |
Member
There was a problem hiding this comment.
What about using a sprintf() call here?
4652e22 to
7b1376b
Compare
e84c812 to
53df89d
Compare
53df89d to
6b7a1fc
Compare
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 15, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Cache] Redis adapter | Q | A | ------------- | --- | Branch | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17441 | License | MIT | Doc PR | - Commits ------- 6b7a1fc [Cache] Finish Redis adapter 4893cbc Added RedisAdapter
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.