Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Cache] Redis adapter #18172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2016
Merged

[Cache] Redis adapter #18172

merged 2 commits into from
Mar 15, 2016

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #17441
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas changed the title Redis adapter [Cache] Redis adapter Mar 15, 2016
javiereguiluz
javiereguiluz reviewed Mar 15, 2016
View reviewed changes
src/Symfony/Component/Cache/Adapter/RedisAdapter.php
*/
protected function doClear($namespace)
{
$this->redis->eval("for _,k in ipairs(redis.call('keys','{$namespace}*')) do redis.call('del',k) end");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using a sprintf() call here?

@nicolas-grekas nicolas-grekas force-pushed the redis_adapter branch 3 times, most recently from 4652e22 to 7b1376b Compare March 15, 2016 12:07
@nicolas-grekas nicolas-grekas mentioned this pull request Mar 15, 2016
Closed
@nicolas-grekas nicolas-grekas force-pushed the redis_adapter branch 2 times, most recently from e84c812 to 53df89d Compare March 15, 2016 16:00
@fabpot
Copy link
Member

fabpot commented Mar 15, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 6b7a1fc into symfony:master Mar 15, 2016
fabpot added a commit that referenced this pull request Mar 15, 2016
@fabpot
feature #18172 [Cache] Redis adapter (gcds, nicolas-grekas)
ded8491 
This PR was merged into the 3.1-dev branch.

Discussion
----------

[Cache] Redis adapter

| Q             | A
| ------------- | ---
| Branch        | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17441
| License       | MIT
| Doc PR        | -

Commits
-------

6b7a1fc [Cache] Finish Redis adapter
4893cbc Added RedisAdapter
@nicolas-grekas nicolas-grekas deleted the redis_adapter branch March 16, 2016 16:09
@fabpot fabpot mentioned this pull request May 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Cache Feature Ready Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @javiereguiluz @carsonbot