Codestin Search App

nicolas-grekas · 2016-03-19T11:12:07Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#18222
License	MIT
Doc PR	-

See https://github.com/symfony/symfony/pull/18232/files?w=1

Because we keep adding features to the bridge, so that one could want some features but not the deprecations helper.
In weak mode, this PR also disables colors.
Fetching the SYMFONY_DEPRECATIONS_HELPER env var is also done lazily to workaround old phpunit versions affected by sebastianbergmann/phpunit#1216

nicolas-grekas · 2016-03-19T11:16:50Z

Status: needs work, for 5.3 support

theofidry · 2016-03-19T11:34:07Z

In weak mode, this PR also disables colors.

That's the only change I'm not really fond of to be honest: if you don't want colors I would expect to set the PHPUnit colors configuration at false.

Otherwise 👍

nicolas-grekas · 2016-03-19T12:18:08Z

@theofidry we don't access to phpunit configuration. PR welcomed if anyone thinks this is of importance.

theofidry · 2016-03-19T12:26:03Z

we don't access to phpunit configuration

Is it because it's something that has been needed until now or there is a reason behind that?

PR welcomed if anyone thinks this is of importance.

In the example of the color, it doesn't really make sense (at least to me) to set this at the bridge level. But I have no idea of how you access to PHPUnit config so if it's too troublesome then it's understandable. It's just a color setting after all...

nicolas-grekas · 2016-03-19T16:20:02Z

Status: needs review
Code updated to work on 5.3

@theofidry that's it: nobody spent time looking for a way to have tighter phpunit integration, because as you said:

It's just a color setting after all...

theofidry · 2016-03-19T16:41:06Z

Fair.

This PR will require to update the doc though.

nicolas-grekas · 2016-03-19T16:50:34Z

@theofidry would you like opening it please?

nicolas-grekas · 2016-03-19T17:18:13Z

Tests added

stof · 2016-03-21T09:58:59Z

-            $mode = preg_match('/^[1-9][0-9]*$/', $mode) ? (int) $mode : 0;
-        }
+
+        $mode = function () use ($mode) {


reusing the same variable name to store the function makes the code much harder to read

stof · 2016-03-21T10:03:40Z

+
+putenv('SYMFONY_DEPRECATIONS_HELPER');
+
+define('PHPUNIT_COMPOSER_INSTALL', __DIR__.'/../../vendor/autoload.php');


would this work when running tests from the root of the project ?

no, that's why they are skipped (see line 3-4)

wouldn't it be better to check for __DIR__.'/../../vendor/autoload.php' instead then ? It would at least be easier to understand

sure it would, but __DIR__ is not correct/does not work in the SKIPIF section context...

actually, we cannot use __DIR__ in skipif as it is not replaced before evaluating the code (which is not done from a file anymore).

btw, would be it possible to support the case of running these tests from the root too ? It would make it easier for contributors to run them.

stof · 2016-03-21T10:04:36Z

@nicolas-grekas shouldn't most of these tests actually be added in older branches ?

stof · 2016-03-21T15:22:38Z

+--TEST--
+Test DeprecationErrorHandler in default mode
+--SKIPIF--
+<?php if (!file_exists('DeprecationErrorHandler.php')) print "skip"; ?>


I suggest giving more details about the reason for the test being skipped (for instance skip can only run from a standalone install of the component).

stof · 2016-03-21T15:39:14Z

right, but it's much simpler for me to make them work on master first, and backport afterwards

Will you backport them before merging this PR though ? It would make the git history cleaner by avoiding to add them twice.

stof · 2016-03-23T09:31:04Z

Looks good to me. 👍

@nicolas-grekas can you answer my previous question ?

stof · 2016-03-23T09:31:13Z

Status: reviewed

…colas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [travis] Upgrade phpunit wrapper & hirak/prestissimo | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Must be merged after #18232 Commits ------- bf465eb [travis] Upgrade phpunit wrapper & hirak/prestissimo

…ATIONS_HELPER (nicolas-grekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [Bridge\PhpUnit] Add "disabled" mode to SYMFONY_DEPRECATIONS_HELPER | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18222 | License | MIT | Doc PR | - See https://github.com/symfony/symfony/pull/18232/files?w=1 Because we keep adding features to the bridge, so that one could want some features but not the deprecations helper. In weak mode, this PR also disables colors. Fetching the SYMFONY_DEPRECATIONS_HELPER env var is also done lazily to workaround old phpunit versions affected by sebastianbergmann/phpunit#1216 Commits ------- 64fe539 [Bridge\PhpUnit] Add "disabled" mode to SYMFONY_DEPRECATIONS_HELPER

joeyhub · 2019-03-19T15:43:45Z

No matter what I do I can't disable the depreciations, can you explain clearly how to do that?

joeyhub · 2019-03-19T15:45:43Z

        );
        $deprecationHandler = function ($type, $msg, $file, $line, $context) use (&$deprecations, $getMode) {
-            if (E_USER_DEPRECATED !== $type) {
+            if (E_USER_DEPRECATED !== $type || DeprecationErrorHandler::MODE_DISABLED === $mode = $getMode()) {


Where is $mode used?

carsonbot added the Status: Needs Review label Mar 19, 2016

nicolas-grekas mentioned this pull request Mar 19, 2016

[PHPUnitBridge] Provide option to disable DeprecationErrorHandler #18222

Closed

nicolas-grekas changed the title ~~[Bridge\PhpUnit] Add "disabled" mode~~ [Bridge\PhpUnit] Add "disabled" mode to SYMFONY_DEPRECATIONS_HELPER Mar 19, 2016

nicolas-grekas force-pushed the phpunit-wa branch from 74963db to 5ce8438 Compare March 19, 2016 11:14

nicolas-grekas added Status: Needs Work and removed Status: Needs Review labels Mar 19, 2016

javiereguiluz added Feature PhpUnitBridge labels Mar 19, 2016

nicolas-grekas force-pushed the phpunit-wa branch from 5ce8438 to 89cd063 Compare March 19, 2016 16:16

carsonbot added Status: Needs Review and removed Status: Needs Work labels Mar 19, 2016

nicolas-grekas force-pushed the phpunit-wa branch from 89cd063 to 13ed5cf Compare March 19, 2016 16:25

nicolas-grekas force-pushed the phpunit-wa branch from 13ed5cf to 49931f4 Compare March 19, 2016 17:17

nicolas-grekas force-pushed the phpunit-wa branch 3 times, most recently from 2e0fa55 to 85852f7 Compare March 19, 2016 17:27

theofidry mentioned this pull request Mar 19, 2016

[PhpUnitBridge] Disable deprecation helper symfony/symfony-docs#6386

Closed

nicolas-grekas force-pushed the phpunit-wa branch from 85852f7 to 8e00abf Compare March 19, 2016 21:55

stof reviewed Mar 21, 2016
View reviewed changes

nicolas-grekas force-pushed the phpunit-wa branch from 8e00abf to 3a65159 Compare March 21, 2016 10:01

stof reviewed Mar 21, 2016
View reviewed changes

nicolas-grekas added the Ready label Mar 21, 2016

stof reviewed Mar 21, 2016
View reviewed changes

nicolas-grekas force-pushed the phpunit-wa branch from b91ee53 to d79d731 Compare March 21, 2016 15:38

nicolas-grekas force-pushed the phpunit-wa branch 11 times, most recently from 3cd458d to 5747dc1 Compare March 23, 2016 08:53

nicolas-grekas mentioned this pull request Mar 23, 2016

[travis] Upgrade phpunit wrapper & hirak/prestissimo #18270

Merged

carsonbot added Status: Reviewed and removed Status: Needs Review labels Mar 23, 2016

[Bridge\PhpUnit] Add "disabled" mode to SYMFONY_DEPRECATIONS_HELPER

64fe539

nicolas-grekas force-pushed the phpunit-wa branch from 5747dc1 to 64fe539 Compare March 23, 2016 13:47

nicolas-grekas merged commit 64fe539 into symfony:master Mar 23, 2016

nicolas-grekas deleted the phpunit-wa branch March 23, 2016 13:50

fabpot mentioned this pull request May 13, 2016

Release v3.1.0-BETA1 #18776

Merged

joeyhub reviewed Mar 19, 2019

View reviewed changes


		putenv('SYMFONY_DEPRECATIONS_HELPER');

		define('PHPUNIT_COMPOSER_INSTALL', __DIR__.'/../../vendor/autoload.php');

Uh oh!

Conversation

nicolas-grekas commented Mar 19, 2016

Uh oh!

nicolas-grekas commented Mar 19, 2016

Uh oh!

theofidry commented Mar 19, 2016

Uh oh!

nicolas-grekas commented Mar 19, 2016

Uh oh!

theofidry commented Mar 19, 2016

Uh oh!

nicolas-grekas commented Mar 19, 2016

Uh oh!

theofidry commented Mar 19, 2016

Uh oh!

nicolas-grekas commented Mar 19, 2016

Uh oh!

nicolas-grekas commented Mar 19, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stof commented Mar 21, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stof commented Mar 21, 2016

Uh oh!

stof commented Mar 23, 2016

Uh oh!

stof commented Mar 23, 2016

Uh oh!

joeyhub commented Mar 19, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants