add @Event annotation and description for KernelEvents::FINISH_REQUES…#18684
Closed
Haehnchen wants to merge 1 commit into
Closed
add @Event annotation and description for KernelEvents::FINISH_REQUES…#18684Haehnchen wants to merge 1 commit into
Haehnchen wants to merge 1 commit into
Conversation
…T and AuthenticationEvents
Member
|
@Haehnchen Shouldn't these new annotation also include the event class name like you did in #18685? |
Contributor
Author
Member
|
Actually, AuthenticationEvents should be fixed in 2.3 and |
This was referenced May 2, 2016
Contributor
Author
|
@stof done |
fabpot
added a commit
that referenced
this pull request
May 3, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- add @event annotation for AuthenticationEvents | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18684 | License | MIT split of #18684 for targeting 2.3 branch Commits ------- e2c1270 add @event annotation for AuthenticationEvents
fabpot
added a commit
that referenced
this pull request
May 3, 2016
This PR was merged into the 2.7 branch. Discussion ---------- add @event annotation for KernelEvents | Q | A | ------------- | --- | Branch | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18684 | License | MIT split of #18684 for targeting 2.7 branch Commits ------- a52e51a add @event annotation for KernelEvents
fabpot
added a commit
that referenced
this pull request
May 3, 2016
…notations defau… (Haehnchen) This PR was submitted for the 3.0 branch but it was merged into the 3.1-dev branch instead (closes #18685). Discussion ---------- move event listener method type hint docs to @event annotations defau… | Q | A | ------------- | --- | Branch? | 3.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | reference to the documentation PR, if any I moved all `listener method receives a "*"` from php docs to "@event". makes them parsable by PhpStorm Plugin without extract class names out of comments. This helps to prefill type hints on method creation. There is also a fallback for doccomments, but it would be much easier to provide a common structure eg for external libs. see also #18684, which adds some missing "@Events" External issue: Haehnchen/idea-php-symfony2-plugin#493  Commits ------- f2c0446 move event listener method type hint docs to @event annotations default value. makes it easily parsable by PhpStorm plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External issue:
Haehnchen/idea-php-symfony2-plugin#493