move event listener method type hint docs to @Event annotations defau…#18685
Closed
Haehnchen wants to merge 1 commit into
Closed
move event listener method type hint docs to @Event annotations defau…#18685Haehnchen wants to merge 1 commit into
Haehnchen wants to merge 1 commit into
Conversation
Contributor
|
This would make a very nice addition to the plugin! |
Member
|
👍 |
Member
|
3.0 is probably not the right target. It should be 2.3 or master/3.1. What do you think? It's not really a new feature, but might cause problem is people are relying on the simple |
…lt value. makes it easily parsable by PhpStorm plugin
2bf6e53 to
a7c77e7
Compare
Contributor
Author
|
i did a rebase on latest changes in 3.0 branch. |
Member
|
Thank you @Haehnchen. |
javiereguiluz
added a commit
to EasyCorp/EasyAdminBundle
that referenced
this pull request
May 6, 2016
This PR was merged into the master branch. Discussion ---------- Added the new @event annotation @Haehnchen, the author of the PHPStorm Symfony plugin, has introduced a new `@Event` annotation in Symfony code (symfony/symfony#18685) He's also updating some bundles (e.g. liip/LiipImagineBundle#732) so we could do the same. In our case this info is not critical because we always use the same generic event object, but still it's a little nice addition. Commits ------- 9755f38 Added the new @event annotation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved all
listener method receives a "*"from php docs to "@event". makes them parsable by PhpStorm Plugin without extract class names out of comments. This helps to prefill type hints on method creation. There is also a fallback for doccomments, but it would be much easier to provide a common structure eg for external libs.see also #18684, which adds some missing "@Events"
External issue:
Haehnchen/idea-php-symfony2-plugin#493