Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Translation] XLIFF Add id to meta data.#18762

Closed
SpacePossum wants to merge 2 commits into
symfony:masterfrom
SpacePossum:master_XLIFF_add_id_to_metadata
Closed

[Translation] XLIFF Add id to meta data.#18762
SpacePossum wants to merge 2 commits into
symfony:masterfrom
SpacePossum:master_XLIFF_add_id_to_metadata

Conversation

@SpacePossum
Copy link
Copy Markdown
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? maybe/no
Deprecations? no
Tests pass? yes
License MIT

I would like to get the id attribute value from parsed XLIFF v1.2 files in the meta data (of the catalogue).

foreach (libxml_get_errors() as $error) {
$errors[] = sprintf('[%s %s] %s (in %s - line %d, column %d)',
LIBXML_ERR_WARNING == $error->level ? 'WARNING' : 'ERROR',
LIBXML_ERR_WARNING === $error->level ? 'WARNING' : 'ERROR',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems unrelated, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, I'll revert it 👍

@javiereguiluz
Copy link
Copy Markdown
Member

👍 I like this change.

@fabpot
Copy link
Copy Markdown
Member

fabpot commented May 12, 2016

Thank you @SpacePossum.

@fabpot fabpot closed this May 12, 2016
fabpot added a commit that referenced this pull request May 12, 2016
This PR was squashed before being merged into the 3.1-dev branch (closes #18762).

Discussion
----------

[Translation] XLIFF Add `id` to meta data.

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      |  no
| New feature?  | yes
| BC breaks?    | maybe/no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

I would like to get the `id` attribute value from parsed XLIFF v1.2 files in the meta data (of the catalogue).

Commits
-------

ad4adca [Translation] XLIFF Add uid=501(fabien) gid=20(staff) groups=20(staff),401(com.apple.sharepoint.group.1),12(everyone),61(localaccounts),79(_appserverusr),80(admin),81(_appserveradm),98(_lpadmin),33(_appstore),100(_lpoperator),204(_developer),395(com.apple.access_ftp),398(com.apple.access_screensharing),399(com.apple.access_ssh) to meta data.
@SpacePossum SpacePossum deleted the master_XLIFF_add_id_to_metadata branch May 12, 2016 20:46
@fabpot fabpot mentioned this pull request May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants