[Translation] XLIFF Add id to meta data.
#18762
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -232,7 +238,7 @@ private function getXmlErrors($internalErrors) | |||
| $errors = array(); | |||
| foreach (libxml_get_errors() as $error) { | |||
| $errors[] = sprintf('[%s %s] %s (in %s - line %d, column %d)', | |||
| LIBXML_ERR_WARNING == $error->level ? 'WARNING' : 'ERROR', | |||
| LIBXML_ERR_WARNING === $error->level ? 'WARNING' : 'ERROR', | |||
There was a problem hiding this comment.
This change seems unrelated, right?
There was a problem hiding this comment.
indeed, I'll revert it 👍
|
👍 I like this change. |
|
Thank you @SpacePossum. |
fabpot
added a commit
that referenced
this pull request
May 12, 2016
This PR was squashed before being merged into the 3.1-dev branch (closes #18762). Discussion ---------- [Translation] XLIFF Add `id` to meta data. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | maybe/no | Deprecations? | no | Tests pass? | yes | License | MIT I would like to get the `id` attribute value from parsed XLIFF v1.2 files in the meta data (of the catalogue). Commits ------- ad4adca [Translation] XLIFF Add uid=501(fabien) gid=20(staff) groups=20(staff),401(com.apple.sharepoint.group.1),12(everyone),61(localaccounts),79(_appserverusr),80(admin),81(_appserveradm),98(_lpadmin),33(_appstore),100(_lpoperator),204(_developer),395(com.apple.access_ftp),398(com.apple.access_screensharing),399(com.apple.access_ssh) to meta data.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to get the
idattribute value from parsed XLIFF v1.2 files in the meta data (of the catalogue).