[travis] Master fixes for HHVM 3.18LTS #21914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Mar 7, 2017
.travis.yml
Outdated
| @@ -95,7 +96,7 @@ script: | |||
| - if [[ $skip ]]; then echo -e "\\n\\e[1;34mIntermediate PHP version $PHP is skipped for pull requests.\\e[0m"; fi | |||
| - if [[ ! $deps && ! $PHP = hhvm* ]]; then echo "$COMPONENTS" | parallel --gnu '$PHPUNIT --exclude-group tty,benchmark,intl-data {}'"$REPORT"; fi | |||
| - if [[ ! $deps && ! $PHP = hhvm* ]]; then echo -e "\\nRunning tests requiring tty"; $PHPUNIT --group tty; fi | |||
| - if [[ ! $deps && $PHP = hhvm* ]]; then $PHPUNIT --exclude-group benchmark,intl-data; fi | |||
| - if [[ ! $deps && $PHP = hhvm* ]]; then $PHPUNIT --exclude-group benchmark,intl-data --stop-on-error; fi | |||
There was a problem hiding this comment.
debugging right now
04139fb to
302bf08
Compare
nicolas-grekas
commented
Mar 7, 2017
|
|
||
| $fresh = false; | ||
| } | ||
| if (!$fresh = class_exists($class, false)) { |
There was a problem hiding this comment.
This change is required to make tests pass. LGTM anyway.
There was a problem hiding this comment.
Can you explain? I don't understand why we would need to make this change.
There was a problem hiding this comment.
Must be a bug with require_once, the file is included twice otherwise. I think it doesn't do any harm so we should merge. (Yes I know...)
There was a problem hiding this comment.
code change move to 2.7, see #21917
302bf08 to
c229c81
Compare
This was referenced Mar 7, 2017
c229c81 to
114d62c
Compare
|
Confirmed green, now split across maintained branches. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 7, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [hhvm] 3.18-related fix | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - See #21914 Commits ------- bc6c569 [hhvm] 3.18-related fix
nicolas-grekas
added a commit
that referenced
this pull request
Mar 7, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- [travis] Master fixes for HHVM 3.18LTS | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21900 | License | MIT | Doc PR | - For some reason, the current HHVM 3.15 consistently crashes in its shutdown sequence on master. Time to move to 3.18? https://github.com/symfony/symfony/pull/21914/files?w=1 Commits ------- 114d62c [travis] Master fixes for HHVM 3.18LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the current HHVM 3.15 consistently crashes in its shutdown sequence on master.
Time to move to 3.18?
https://github.com/symfony/symfony/pull/21914/files?w=1