Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle][Serializer] Add option to register a circular_reference_handler #22011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Mar 15, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Right now, it's quite hard (especially for new comers) to register a CircularReferenceHandler:

screenshot1


This PR introduce an option to wire a service to the internal Object Normalizer.

@lyrixx lyrixx force-pushed the serializer-circular-reference-handler branch from cbdc24d to 0a638f5 Compare March 15, 2017 16:33
@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Mar 15, 2017
Nek- added a commit to Nek-/symfony-docs that referenced this pull request Mar 15, 2017
This is added by symfony/symfony#22011
This commit also fix missing serializer related missing options in the yaml
config example.
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great new feature! But can you add a test?

@fabpot
Copy link
Member

fabpot commented Mar 22, 2017

Thank you @lyrixx.

@fabpot fabpot merged commit 0a638f5 into symfony:master Mar 22, 2017
fabpot added a commit that referenced this pull request Mar 22, 2017
… circular_reference_handler (lyrixx)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[FrameworkBundle][Serializer] Add option to register a circular_reference_handler

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

---

Right now, it's quite hard (especially for new comers) to register a CircularReferenceHandler:

![screenshot1](https://cloud.githubusercontent.com/assets/408368/23959193/ce19bcec-09a4-11e7-82c7-80abd7b7f602.png)

---

This PR introduce an option to wire a service to the internal Object Normalizer.

Commits
-------

0a638f5 [FrameworkBundle][Serializer] Add option to register a "circular_reference_handler"
@lyrixx lyrixx deleted the serializer-circular-reference-handler branch March 22, 2017 21:11
xabbuh added a commit to symfony/symfony-docs that referenced this pull request Apr 15, 2017
…option to reference: circular_reference_handler (Nek-)

This PR was merged into the master branch.

Discussion
----------

[FrameworkBundle][Serializer] Add new framework bundle option to reference: circular_reference_handler

This PR provides documentation for this other PR symfony/symfony#22011

It should not be merged before the related Symfony PR is merged.

It also fixes missing options in the example YAML config file.

Commits
-------

964c31e Add new framework bundle option to reference: circular_reference_handler
@fabpot fabpot mentioned this pull request May 1, 2017
fabpot added a commit that referenced this pull request Feb 19, 2018
…rence_handler (dunglas)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Add missing XML config for circular_reference_handler

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

* Add missing XML config for circular_reference_handler (#22011)
* Add tests

Commits
-------

611ff59 [FrameworkBundle] Add missing XML config for circular_reference_handler. Add tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants