-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Added the docs for WebServerBundle #22471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We never put documentation in the main Symfony repo. This should go in symfony-docs |
|
||
``--filter`` | ||
Any `ExpressionLanguage`_ compatible expression used to filter the log | ||
messages before displaying them (e.g. ``"level > 200 or channel in [\'app\', \'doctrine\']"``). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should document the available variables
If we don't document this in the bundle's repository, then we won't be able to display it on https://symfony.com/doc/bundles/ Besides, other bundles already have short docs in this repo: https://github.com/symfony/monolog-bundle/blob/master/Resources/doc/index.rst and https://github.com/symfony/swiftmailer-bundle/blob/master/Resources/doc/index.rst |
Ah, so the difference between this bundle and those bundles is that they are in separate repositories. But, since we're moving towards not including So, 👍 in theory, but I kinda doubt that Fabien will want big docs like this living in this repo. Would it be a better idea (for bundles that are actually inside symfony/symfony) to add a |
I like the idea of @weaverryan |
I've just pushed an alternative in #22607. I think it's better to not duplicate documentation. Commands should be documented so that help is available on the CLI. I've also reused the description of the component in the README. That should be enough I think. |
@fabpot Basic usage and installation should be documented on the Symfony website under the |
@robfrawley Installation is a no-brainer with Flex. And there is no documentation except the CLI commands as the bundle is just about that. I don't see the point. |
This PR was merged into the 3.3-dev branch. Discussion ---------- Add some missing docs for the web server bundle | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This is an alternative to #22471 Commits ------- 987a681 added some missing docs for the web server bundle
This initial doc is needed to add the WebServerBundle to this page: https://symfony.com/doc/bundles/