Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added the docs for WebServerBundle #22471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets symfony/symfony-docs#7325
License MIT
Doc PR -

This initial doc is needed to add the WebServerBundle to this page: https://symfony.com/doc/bundles/

@stof
Copy link
Member

stof commented Apr 19, 2017

We never put documentation in the main Symfony repo. This should go in symfony-docs


``--filter``
Any `ExpressionLanguage`_ compatible expression used to filter the log
messages before displaying them (e.g. ``"level > 200 or channel in [\'app\', \'doctrine\']"``).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should document the available variables

@javiereguiluz
Copy link
Member Author

If we don't document this in the bundle's repository, then we won't be able to display it on https://symfony.com/doc/bundles/

Besides, other bundles already have short docs in this repo: https://github.com/symfony/monolog-bundle/blob/master/Resources/doc/index.rst and https://github.com/symfony/swiftmailer-bundle/blob/master/Resources/doc/index.rst

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Apr 20, 2017
@weaverryan
Copy link
Member

Ah, so the difference between this bundle and those bundles is that they are in separate repositories. But, since we're moving towards not including symfony/symfony, it does indeed make more sense to begin documenting the individual bundles as if they were separated.

So, 👍 in theory, but I kinda doubt that Fabien will want big docs like this living in this repo. Would it be a better idea (for bundles that are actually inside symfony/symfony) to add a bundles/ directory in symfony/symfony-docs and update symfony.com to be able to pull from that?

@stof
Copy link
Member

stof commented Apr 29, 2017

I like the idea of @weaverryan

@fabpot
Copy link
Member

fabpot commented May 2, 2017

I've just pushed an alternative in #22607. I think it's better to not duplicate documentation. Commands should be documented so that help is available on the CLI. I've also reused the description of the component in the README. That should be enough I think.

@robfrawley
Copy link
Contributor

robfrawley commented May 2, 2017

@fabpot Basic usage and installation should be documented on the Symfony website under the bundles/ path, regardless of the completeness of the CLI documentation, IMHO. Especially as more and more items are split into their own packages (regardless of the fact that they all actually exist in a single root repo). What did you think of creating a bundle documentation root within symfony-docs that symfony.com learns to also pull from?

@fabpot
Copy link
Member

fabpot commented May 2, 2017

@robfrawley Installation is a no-brainer with Flex. And there is no documentation except the CLI commands as the bundle is just about that. I don't see the point.

fabpot added a commit that referenced this pull request May 3, 2017
This PR was merged into the 3.3-dev branch.

Discussion
----------

Add some missing docs for the web server bundle

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This is an alternative to #22471

Commits
-------

987a681 added some missing docs for the web server bundle
@fabpot fabpot closed this May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants