Keep s-maxage when expiry and validation are used in combination #23130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be rebased now :) |
…ould not defeat expiration on the combined response
|
Note to self: Don't open three different PRs at once that change the same part of code, will save yourself a lot of work. |
|
@fabpot rebased |
|
@mpdude Actually, that would have saved a lot of work for me as well :) At first, I didn't realized that the 3 PRs were about the same topic. In such a case, I generally ask to merge them all into one PR. |
|
I was unsure as to whether you agree that all three are bugs or correct behavior. |
|
Thank you @mpdude. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2017
…nation (mpdude) This PR was merged into the 2.7 branch. Discussion ---------- Keep s-maxage when expiry and validation are used in combination | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | (Symfony) docs say that [expiration wins over validation](https://symfony.com/doc/current/http_cache/validation.html). So, a) when both the master and embedded response are public with an s-maxage, the result should be public as well and use the lower s-maxage of both, *also* in the case that the embedded response carries validation headers. (The cache may use those for revalidating the embedded response once it has become stale, but that does not impact expiration-based caching of the combined response.) b) when both the master and embedded response are public with an s-maxage, the result should be public as well and use the lower s-maxage of both, *also* in the case that the master response carries validation headers. However, those *must not* be passed on to the client: They do not apply to the combined response, but may only be used by the cache itself to revalidate the (raw) master response. Commits ------- 09bcbc7 Embedding a response that combines expiration and validation, that should not defeat expiration on the combined response
|
@fabot Could you do me a favor and merge at least 2.7 into 2.8, if your processes allow it and it is no big deal? |
|
@mpdude Done! |
This was referenced Jul 3, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Symfony) docs say that expiration wins over validation. So,
a) when both the master and embedded response are public with an s-maxage, the result should be public as well and use the lower s-maxage of both, also in the case that the embedded response carries validation headers. (The cache may use those for revalidating the embedded response once it has become stale, but that does not impact expiration-based caching of the combined response.)
b) when both the master and embedded response are public with an s-maxage, the result should be public as well and use the lower s-maxage of both, also in the case that the master response carries validation headers. However, those must not be passed on to the client: They do not apply to the combined response, but may only be used by the cache itself to revalidate the (raw) master response.