Calling the count() method will have the same result, isn't it?

count():

• obfuscates intent a lot.
• no autocomplete
• needlessly "iterates" over all constraints instead of just checking if it has at least one constraint

Please see referenced issue, I didn't make up this DX issue

no autocomplete

why? it's a method, so works with autocomplete, isn't it?

needlessly "iterates" over all constraints

where? the code does just a count($this->violations), did I miss something?

I didn't make up this DX issue

I'm sure you didn't. We just know how each new public methods adds up to the maintenance burden, so we challenge changes, that's just normal.

why? it's a method, so works with autocomplete, isn't it?

Yes it does via calling ->count(), but official way (according docs) is to use count($errors). That's also what could be improved - there is currently no "correct" way to do this. I will do the PR for docs if this will be merged. Also even when you call ->count(), autocomplete won't autocomplete > 0 for you and without it, it won't pass coding guideliness in top teams since if ($errors->count()) is even less explicit than if ($errors->count() > 0)

where? the code does just a count($this->violations), did I miss something?

Ok I thought PHP needs to do that internally to get the count, turns out I was wrong, but count($array) is still 2x slower than (bool)$array.

we challenge changes, that's just normal.

Gotcha, I just wish ideas were challenged inside an issue first. I didn't see any complaints there

This is similar PR which seems to have big support #23471

#23471 is quite different: it increase performances by stopping the search for files as soon as one of them is found where here the performance improvement are only a few less instructions.

Both are mainly DX improvements. To make code easier to type and make intent clearer.

@symfony/deciders we need to make a decision here. Personally I'm "-0" :)

Same. I don't really see a benefit and it'll not be part of the ConstraintViolationListInterface interface. So it's quite limited.

same for me

I see. Thanks for consideration. Close the related issue as well please.