[DI] Turn private defs to non-public ones before removing passes #24468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Oct 6, 2017
| @@ -69,6 +69,8 @@ public function __construct() | |||
| new CheckCircularReferencesPass(), | |||
| new CheckReferenceValidityPass(), | |||
| new CheckArgumentsValidityPass(false), | |||
| ), -100 => array( | |||
There was a problem hiding this comment.
Should be moved before removing
74e0ba2 to
ca8b0ba
Compare
ca8b0ba to
e5d0934
Compare
|
PR ready |
xabbuh
approved these changes
Oct 7, 2017
stof
reviewed
Oct 9, 2017
| @@ -71,6 +71,12 @@ public function __construct() | |||
| new CheckArgumentsValidityPass(false), | |||
| )); | |||
|
|
|||
| $this->beforeRemovingPasses = array( | |||
| -100 => array( | |||
| new ResolvePrivatesPass(), | |||
There was a problem hiding this comment.
This could even be the first removing pass instead.
There was a problem hiding this comment.
which one is better? semantically, this is not a removing pass.
Is there any technical reason that would help decide?
otherwise, I think we should leave as is, isn't it?
There was a problem hiding this comment.
Well, "optimization" passes are not really about optimizing either 😄
fabpot
approved these changes
Oct 10, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 10, 2017
…passes (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Turn private defs to non-public ones before removing passes | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24465 | License | MIT | Doc PR | - As spotted by @stof in #24465 (comment). Commits ------- e5d0934 [DI] Turn private defs to non-public ones before removing passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted by @stof in #24465 (comment).