[PropertyAccess] add more information to NoSuchPropertyException Message #25450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b67d768 to
590dc8a
Compare
590dc8a to
f835e19
Compare
f835e19 to
dee00f8
Compare
|
fabbot failure is a false positive. |
|
Why not cover this change with test using |
|
Because I did not find an easy way to do it. But I can look into it to add
one
Le mar. 12 déc. 2017 à 17:13, Konstantin Myakshin <[email protected]>
a écrit :
… Why not cover this change with test using expectsException?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25450 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADSq8tximFTQC2YdXN4ZHERAOCJ5e_bVks5s_qZGgaJpZM4Q9_yn>
.
|
dunglas
approved these changes
Dec 13, 2017
fabpot
approved these changes
Dec 14, 2017
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Dec 14, 2017
…yException Message (Simperfit) This PR was merged into the 4.1-dev branch. Discussion ---------- [PropertyAccess] add more information to NoSuchPropertyException Message | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | no | Fixed tickets | #24742 | License | MIT | Doc PR | Add more context to NoSuchPropertyException as discussed in the issue. Commits ------- dee00f8 [PropertyAccess] add more information to NoSuchPropertyException Message
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more context to NoSuchPropertyException as discussed in the issue.