support sapi_windows_vt100_support for php 7.2+ #25972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@symfony/deciders should we merge this in 2.7, or should we consider it a new feature ? For reference, the automatic detection of Mintty was backported to 2.3 in the past (see #15915), so merging in 2.7 looks fine. |
|
For 2.7: infrastructure-related changes are bug fixes (similarly to PR fixing issues with newer versions of PHP) |
|
travis ci fails due to an issue on the base branch, I'll rebase these changes when it has been fixed if necessary. |
nicolas-grekas
approved these changes
Jan 30, 2018
lyrixx
approved these changes
Jan 30, 2018
javiereguiluz
approved these changes
Jan 31, 2018
xabbuh
approved these changes
Jan 31, 2018
|
Thank you @jhdxr. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 31, 2018
This PR was merged into the 2.7 branch. Discussion ---------- support sapi_windows_vt100_support for php 7.2+ | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | See below | License | MIT | Doc PR | N/A php 7.2 enabled color support on windows(>=10.0.10586) and introduced a new function called `sapi_windows_vt100_support` to get and set the state. this PR add the support for this new function, so users on windows can see the colorful world again with php 7.2+. Commits ------- 5bbb77b support sapi_windows_vt100_support for php 7.2+
This was referenced Feb 28, 2018
Closed
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php 7.2 enabled color support on windows(>=10.0.10586) and introduced a new function called
sapi_windows_vt100_supportto get and set the state. this PR add the support for this new function, so users on windows can see the colorful world again with php 7.2+.