Make ProgressBar::setMaxSteps public #26449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A test for the described use case would be nice. Also a test for setting the value for a progress bar that didn't have max steps earlier. |
|
This is simple setter and is tested by proxy in existing integration tests. Will write test if required by maintainers. |
|
If you change from private to public, I think a test is needed. |
|
test added |
Destroy666x
approved these changes
Mar 12, 2018
| { | ||
| $this->format = null; |
There was a problem hiding this comment.
is this a bug fix? or a behavioral BC break?
There was a problem hiding this comment.
Bug fix. Wasn't issue before though, because this method was being called on the start only. Please note that format explicitly set by user is saved in different property.
There was a problem hiding this comment.
got it
what about moving the method up with other public ones?
This is useful in cases when target of tracking changes its size during progress advancement.
nicolas-grekas
approved these changes
Mar 19, 2018
fabpot
approved these changes
Mar 19, 2018
|
Thank you @ostrolucky. |
fabpot
added a commit
that referenced
this pull request
Mar 19, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- Make ProgressBar::setMaxSteps public | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24100 | License | MIT | Doc PR | - This is useful in cases when target of tracking changes its size during progress advancement. My exact use case is showing progress of file upload for file which is still being downloading. Commits ------- 2b3c37a Make ProgressBar::setMaxSteps public
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in cases when target of tracking changes its size during progress advancement. My exact use case is showing progress of file upload for file which is still being downloading.