Support phpdbg SAPI in Debug::enable() #26677
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be ok as bug fix on 2.7 on my side. |
PHPDBG is a CLI PHP debugger which could be useful for debugging in development or for running PHPUnit tests with code coverage faster compared to XDebug. It has CLI characteristics, but it runs as a different SAPI.
|
@nicolas-grekas Updated as a bug fix on top of 2.7. |
ogizanagi
suggested changes
Mar 26, 2018
| 2.7.1 | ||
| ----- | ||
|
|
||
| * fix support for PHPDBG SAPI in `Debug::enable()` |
There was a problem hiding this comment.
This must be reverted. We only add new entries on minor versions, for features.
ogizanagi
approved these changes
Mar 26, 2018
|
On a separate note, there are quite a few places where checks for CLI hard-code the |
|
Thank you @hkdobrev. |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2018
This PR was squashed before being merged into the 2.7 branch (closes #26677). Discussion ---------- Support phpdbg SAPI in Debug::enable() | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | <!-- required for new features --> PHPDBG is a CLI PHP debugger which could be useful for debugging in development or for running PHPUnit tests with code coverage faster compared to XDebug. It has CLI characteristics, but it runs as a different SAPI. Commits ------- 49a144f Support phpdbg SAPI in Debug::enable()
|
@hkdobrev : Yes, if there are other places where this makes sense, a PR fixing it all is always appreciated :) |
fabpot
added a commit
that referenced
this pull request
Apr 3, 2018
This PR was squashed before being merged into the 2.7 branch (closes #26749). Discussion ---------- Add PHPDbg support to HTTP components | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This is a follow-up to #26677. Turns out there aren't that many remaining instances of `PHP_SAPI` checks without considering `phpdbg` where it's needed. Commits ------- 60dd79c Add PHPDbg support to HTTP components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPDBG is a CLI PHP debugger which could be useful for debugging in development or for running PHPUnit tests with code coverage faster compared to XDebug.
It has CLI characteristics, but it runs as a different SAPI.