[Console] Use UTF-8 bullet for listing #26698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Be careful. That's one of the multiple characters that don't work on Windows. See https://github.com/sindresorhus/figures |
|
Now ready :) |
stof
reviewed
Mar 28, 2018
| private function getFixtureFilename($name) | ||
| { | ||
| $format = $this->getFormat(); | ||
| $file = ($baseDir = __DIR__.'/../../Fixtures/Descriptor').'/'.$name.'.'.$format; |
There was a problem hiding this comment.
can you move the $baseDir assignement to its own statement ? Nested assignments are not that readable.
|
Duplicating expected outputs for Windows may be unwanted. Can't we use matchesFormat or str_replace bullets instead (and create a dedicated test case for this behavior)? |
|
the files are globbed.. i found this the easiest, To maintain and be future proof. Not aiming for in-test formatting hassle / excluding these fixtures into separate tests. |
fabpot
approved these changes
Mar 30, 2018
ogizanagi
approved these changes
Mar 30, 2018
chalasr
approved these changes
Mar 30, 2018
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Mar 30, 2018
This PR was squashed before being merged into the 4.1-dev branch (closes #26698). Discussion ---------- [Console] Use UTF-8 bullet for listing | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Inspired by the new table style, this updates the listing style. before  after  Commits ------- d1e4acb [Console] Use UTF-8 bullet for listing
This was referenced Mar 30, 2018
|
reverted, see discussion on #26718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the new table style, this updates the listing style.
before
after