-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Console] Use UTF-8 triangle for question prompt #26718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, doesn't work on windows. Use these https://github.com/sindresorhus/figures
@ro0NL did you test it on mac ? doesn't seem to work on mine neither |
It displays as a square (Mac OS X). |
Sorry.. linux-developer here :) Anyway i just got aware of #11326 also.. which seems competing and is a different approach overall. In general something like Status: needs work |
@ro0NL this one should work on macOS: https://www.utf8icons.com/character/9656/black-right-pointing-small-triangle |
Ok. lets see, if we can ship this little enhancement before #11326 that's nice i guess. New icon works for me :) |
Works on windows as well. But wouldn't it be better to use the one from #11326? Or is this one going to replace the one there? |
I'd say the new small triangle looks worse than the existing |
I find it a bit too much subtil. Output on OS X (iTerm with 12pt Monaco font): original: new (https://www.utf8icons.com/character/9656/black-right-pointing-small-triangle): What about using the same as in #11326, i.e https://www.utf8icons.com/character/10095/heavy-right-pointing-angle-quotation-mark-ornament: ? But anyway it may depends too much on the font used. We won't find a perfect fit. |
I like β― most, even on your screenshot. But it does not work on windows. We could really use Figure helper |
lets keep it as is, |
I think @nicolas-grekas is right. After all, that's not like it's much better and could introduce some bugs on some platforms. For that reason, I'm going to revert #26698, so that we get more time to evaluate the impacts and have only one PR that does all the changes. |
Fair. I see the hassle it brings.. What amazes me is this concept of "partial UTF" support accros platforms, totally defeating UTF :D |
Now inspired by #26698, this updates the prompt icon :) Havent looked at tests/windows yet... but i find it very pretty :}
Before
After
Move forward?
ref https://www.utf8icons.com/character/9205/black-medium-right-pointing-triangle