Thanks to visit codestin.com
Credit goes to github.com

Skip to content

hotfix: fix text descriptor test #26726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

hotfix: fix text descriptor test #26726

wants to merge 1 commit into from

Conversation

Simperfit
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR not needed

Fix test of text descriptor by using the right value.

@ro0NL
Copy link
Contributor

ro0NL commented Mar 31, 2018 •
edited
Loading

@Simperfit curious.. AFAIK tests we're ok on appveyor and now fail:

- • Symfony\Bridge\Doctrine\Form\Type\EntityType\n
+ * Symfony\Bridge\Doctrine\Form\Type\EntityType\n

edit: in fact i think i forgot to raise composer deps in Form and FrameworkBundle..

ref #26698

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Mar 31, 2018
@Simperfit Simperfit force-pushed the hotfix/fix-test-for-text-descriptor branch 2 times, most recently from 00a1bac to 75738e8 Compare April 1, 2018 07:35
@Simperfit Simperfit force-pushed the hotfix/fix-test-for-text-descriptor branch from 75738e8 to 4c2bd62 Compare April 1, 2018 07:37
xabbuh
xabbuh approved these changes Apr 1, 2018
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure doesn't seem to be related.

@nicolas-grekas
Copy link
Member

Closing as #26698 has been reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
5 participants
@Simperfit @ro0NL @nicolas-grekas @xabbuh @carsonbot