[Finder] Update RealIteratorTestCase #27508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (DIRECTORY_SEPARATOR === $file[strlen($file) - 1]) { | ||
| @rmdir($file); | ||
| $paths = new \RecursiveIteratorIterator( | ||
| new \RecursiveDirectoryIterator( |
There was a problem hiding this comment.
please use 4 spaces indentation
| } else { | ||
| @unlink($file); | ||
| unlink($path); |
There was a problem hiding this comment.
I'd suggest to keep the silencing operators (and add it above)
|
My current patch is based on master, should i open a new PR on 2.8 or what should i do about this? |
…tierderuette) This PR was submitted for the 3.4 branch but it was merged into the 2.8 branch instead (closes symfony#27630). Discussion ---------- [Validator][Form] Remove BOM in some xlf files | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | | Fixed tickets | #... | License | MIT | Doc PR | symfony/symfony-docs#... I removed first blank space from some xml files It caused this error during cache:clear [ERROR 4] Start tag expected, '<' not found (in n/a - line 1, column 1) Commits ------- 0bc53d6 [Validator] Remove BOM in some xlf files
|
Thank you @flip111. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 19, 2018
This PR was submitted for the master branch but it was squashed and merged into the 2.8 branch instead (closes #27508). Discussion ---------- [Finder] Update RealIteratorTestCase | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27480 | License | MIT | Doc PR | n/a Makes the entire test directory empty instead of trying to delete particular files and directories. The old method failed when trying to remove a directory which was not empty. Commits ------- 7d0ebd4 [Finder] Update RealIteratorTestCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the entire test directory empty instead of trying to delete particular files and directories. The old method failed when trying to remove a directory which was not empty.