4.1 #27810
Closed
4.1 #27810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsion configs (xabbuh) This PR was merged into the 4.1 branch. Discussion ---------- [DependencyInjection] fix handling of empty DI extension configs | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#27707 | License | MIT | Doc PR | Commits ------- 05d4bcb fix handling of empty DI extension configs
This PR was merged into the 3.4 branch. Discussion ---------- [Lock] Fix SemaphoreStoreTest on OS X | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | symfony#27755 (review) <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A As spotted in symfony#27755 (review), for OS X. If other OS X users could give it a try (`/phpunit src/Symfony/Component/Lock/ --filter=SemaphoreStoreTest`), that would be awesome. Commits ------- 9055611 [Lock] Fix SemaphoreStoreTest on OS X
…groups (sroze) This PR was merged into the 4.1 branch. Discussion ---------- [Serializer] Class discriminator and serialization groups | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#27641 | License | MIT | Doc PR | ø It turns out the discriminator mapping does not work well with the serialization groups. This is fixing it (+ a little bit of cleaning in the tests). Commits ------- c91b7af Ensure the class discriminator mechanism works with serialization groups as well
This PR was merged into the 3.4 branch. Discussion ---------- [Form] Fix fixtures for forward compat | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | https://travis-ci.org/symfony/symfony/jobs/398533738#L4394-L4407 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Completes symfony#27771 in order to fix https://travis-ci.org/symfony/symfony/jobs/398533738#L4394-L4407. As the Closure signature is variable, we cannot assume the exact number of whitespaces after it, nor if it will or not overtake the length of the `file:` line. So let's just assume an undetermined nb of whitespaces. Commits ------- 582d797 [Form] Fix fixtures for forward compat
* 3.4: [Form] Fix fixtures for forward compat [Lock] Fix SemaphoreStoreTest on OS X
* 4.0: [Form] Fix fixtures for forward compat [Lock] Fix SemaphoreStoreTest on OS X
…(antograssiot) This PR was merged into the 4.1 branch. Discussion ---------- [Workflow] Update phpdoc to fit a used className | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | none It will just help IDE and static analysis tools to work correctly. I could also add a `use Symfony\Component\Workflow\Workflow;` if you prefer Commits ------- 89470f1 [Workflow] Update phpdoc to fit a used className
|
Closing in favour of #27816, as it only contains the right commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing this bugs:
voodoo-dn/serializer-bug@0aa4a57
On normalization trying get property from class which not exists(because merged whole attribute list from class discriminator map)
voodoo-dn/serializer-bug@41ae6e8
Associated objects are not deserialized
For example: DummyA has association with DummyB, but on deserialization(json string for example) instead of passing DummyB object via DummyA::setDummyB(), array passed to this method.