Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MonologBridge] Prefer PSR-3 to interact with Monolog in tests #27882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2018
Merged

[MonologBridge] Prefer PSR-3 to interact with Monolog in tests #27882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Symfony/Bridge/Monolog/Tests/Handler/ConsoleHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,19 +180,19 @@ public function testLogsFromListeners()

$dispatcher = new EventDispatcher();
$dispatcher->addListener(ConsoleEvents::COMMAND, function () use ($logger) {
$logger->addInfo('Before command message.');
$logger->info('Before command message.');
});
$dispatcher->addListener(ConsoleEvents::TERMINATE, function () use ($logger) {
$logger->addInfo('Before terminate message.');
$logger->info('Before terminate message.');
});

$dispatcher->addSubscriber($handler);

$dispatcher->addListener(ConsoleEvents::COMMAND, function () use ($logger) {
$logger->addInfo('After command message.');
$logger->info('After command message.');
});
$dispatcher->addListener(ConsoleEvents::TERMINATE, function () use ($logger) {
$logger->addInfo('After terminate message.');
$logger->info('After terminate message.');
});

$event = new ConsoleCommandEvent(new Command('foo'), $this->getMockBuilder('Symfony\Component\Console\Input\InputInterface')->getMock(), $output);
Expand Down
26 changes: 13 additions & 13 deletions src/Symfony/Bridge/Monolog/Tests/LoggerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function testGetLogsWithoutDebugProcessor()
$handler = new TestHandler();
$logger = new Logger(__METHOD__, array($handler));

$this->assertTrue($logger->error('error message'));
$logger->error('error message');
$this->assertSame(array(), $logger->getLogs());
}

Expand All @@ -33,7 +33,7 @@ public function testCountErrorsWithoutDebugProcessor()
$handler = new TestHandler();
$logger = new Logger(__METHOD__, array($handler));

$this->assertTrue($logger->error('error message'));
$logger->error('error message');
$this->assertSame(0, $logger->countErrors());
}

Expand All @@ -43,7 +43,7 @@ public function testGetLogsWithDebugProcessor()
$processor = new DebugProcessor();
$logger = new Logger(__METHOD__, array($handler), array($processor));

$this->assertTrue($logger->error('error message'));
$logger->error('error message');
$this->assertCount(1, $logger->getLogs());
}

Expand All @@ -53,15 +53,15 @@ public function testCountErrorsWithDebugProcessor()
$processor = new DebugProcessor();
$logger = new Logger(__METHOD__, array($handler), array($processor));

$this->assertTrue($logger->debug('test message'));
$this->assertTrue($logger->info('test message'));
$this->assertTrue($logger->notice('test message'));
$this->assertTrue($logger->warning('test message'));
$logger->debug('test message');
$logger->info('test message');
$logger->notice('test message');
$logger->warning('test message');

$this->assertTrue($logger->error('test message'));
$this->assertTrue($logger->critical('test message'));
$this->assertTrue($logger->alert('test message'));
$this->assertTrue($logger->emergency('test message'));
$logger->error('test message');
$logger->critical('test message');
$logger->alert('test message');
$logger->emergency('test message');

$this->assertSame(4, $logger->countErrors());
}
Expand All @@ -72,7 +72,7 @@ public function testGetLogsWithDebugProcessor2()
$logger = new Logger('test', array($handler));
$logger->pushProcessor(new DebugProcessor());

$logger->addInfo('test');
$logger->info('test');
$this->assertCount(1, $logger->getLogs());
list($record) = $logger->getLogs();

Expand Down Expand Up @@ -101,7 +101,7 @@ public function testClear()
$logger = new Logger('test', array($handler));
$logger->pushProcessor(new DebugProcessor());

$logger->addInfo('test');
$logger->info('test');
$logger->clear();

$this->assertEmpty($logger->getLogs());
Expand Down