-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Fix !important
in VarDumper stylesheet
#28107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 4.1: [DI] fix undefined offset in InlineServiceDefinitionsPass [Security/Http] Fix deps conflict
…Context deprecations (chalasr) This PR was merged into the 4.2-dev branch. Discussion ---------- [Security][SecurityBundle] FirewallMap/FirewallContext deprecations | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Next to symfony#24805. Commits ------- a71ba78 [Security][SecurityBundle] FirewallMap/FirewallContext deprecations
* 4.1: (26 commits) Revert "bug symfony#27312 Supress deprecation notices thrown when getting private servies from container in tests (arderyp)" [HttpKernel] reset kernel start time on reboot Add code of Conduct links in our README bumped Symfony version to 4.0.12 [FrameworkBundle] Fix using test.service_container when Client is rebooted [DI] never inline lazy services updated VERSION for 4.0.11 updated CHANGELOG for 4.0.11 bumped Symfony version to 3.4.12 updated VERSION for 3.4.11 updated CHANGELOG for 3.4.11 Default testsuite to latest PHPUnit 6.* [Github] Update the pull-request template bumped Symfony version to 2.8.42 updated VERSION for 2.8.41 updated CHANGELOG for 2.8.41 Tweak Argon2 test config [HttpFoundation] Fix cookie test with xdebug [FrameworkBundle] cleanup generated test container [Serializer] Check the value of enable_max_depth if defined ...
* 4.1: [HttpKernel] Dont reset start time when not needed
* 4.1: [HttpKernel] fix test
* 4.1: [Routing] Account for greediness when merging route patterns
… based on FQCN (Iltar van der Berg) This PR was squashed before being merged into the 4.2-dev branch (closes symfony#26981). Discussion ---------- No more support for custom anon/remember tokens based on FQCN | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | symfony#26940 | License | MIT | Doc PR | ~ This PR deprecates the ability to configure a custom anonymous and remember me token class, via the AuthenticationTrustResolver. The only change required _if_ you have changed the token classes like this, is to extend the Anonymous/RememberMe token classes. Commits ------- 860d454 No more support for custom anon/remember tokens based on FQCN
…che pools (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] Allow configuring taggable cache pools | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#25903 | License | MIT | Doc PR | symfony/symfony-docs#9652 This PR adds a new configuration option for cache pools: ```yaml framework: cache: pools: app.taggable_pool: tags: true app.taggable_pool_with_separate_store_for_tags: tags: app.my_pool_for_tags ``` Commits ------- 896be4c [FrameworkBundle] Allow configuring taggable cache pools
…ant) This PR was merged into the 4.2-dev branch. Discussion ---------- [Finder] added "use natural sort" option | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#26930 | License | MIT | Doc PR | symfony/symfony-docs#9671 Added `$useNaturalSort` optional argument to `Finder::sortByName()` method. If it is specified and equals to `true`, ["natural sort order" algorithm](https://en.wikipedia.org/wiki/Natural_sort_order) will be applied, which means that `strnatcmp` function will be used instead of `strcmp` (see symfony#26930 for details). Commits ------- e697c7d [Finder] added "use natural sort" option
…t dependency (fabpot) This PR was merged into the 4.2-dev branch. Discussion ---------- [WebProfilerBundle] Make Twig bundle an explicit dependency | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#26115 | License | MIT Let's make Twig bundle an explicit dependency of WebProfilerBundle. That's better for DX and as Silex won't be maintained when 4.2 is out, it's the right time to do so. Commits ------- cac37ca [WebProfilerBundle] made Twig bundle an explicit dependency
…o type extractor (sroze) This PR was merged into the 4.2-dev branch. Discussion ---------- [PropertyInfo] Add an alias to the property info type extractor | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#27139 | License | MIT | Doc PR | ø As spotted in symfony#27139, we only alias the main PropertyInfo interface but we don't alias the other one, gathering only the types (while we implement it). This fixes the "problem" of auto-wiring it. Commits ------- bbbcd46 Add an alias to the property info type extractor
…nt (sroze) This PR was squashed before being merged into the 4.2-dev branch (closes symfony#27429). Discussion ---------- [PropertyInfo] Auto-enable PropertyInfo component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | ø The PropertyInfo component (used by the Serializer to provide more insights from PhpDocs, etc...) is disabled by default, not sure why. This enables it by default when the component is installed. Commits ------- 06ea72e [PropertyInfo] Auto-enable PropertyInfo component
…zanagi) This PR was merged into the 4.2-dev branch. Discussion ---------- [Messenger][Profiler] Show dispatch caller | Q | A | ------------- | --- | Branch? | 4.2 <!-- see below --> | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Just something I missed on my checklist in the first PR:  Commits ------- 1c2f43f [Messenger][Profiler] Show dispatch caller
* 4.1: (22 commits) [HttpKernel] Fix restoring trusted proxies in tests Update UPGRADE-4.0.md [Messenger] Fix suggested enqueue adapter package bumped Symfony version to 4.1.1 updated VERSION for 4.1.0 updated CHANGELOG for 4.1.0 Insert correct parameter_bag service in AbstractController Revert "feature symfony#26702 Mark ExceptionInterfaces throwable (ostrolucky)" CODEOWNERS: some more rules removed unneeded comments in tests removed unneeded comments in tests Change PHPDoc in ResponseHeaderBag::getCookies() to help IDEs [HttpKernel] fix registering IDE links update UPGRADE-4.1 for feature symfony#26332 Form field help option [HttpKernel] Set first trusted proxy as REMOTE_ADDR in InlineFragmentRenderer. [Process] Consider \"executable\" suffixes first on Windows Triggering RememberMe's loginFail() when token cannot be created bumped Symfony version to 4.1.0 updated VERSION for 4.1.0-BETA3 updated CHANGELOG for 4.1.0-BETA3 ...
…che.app.taggable to CacheInterface (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Cache] Remove TaggableCacheInterface, alias cache.app.taggable to CacheInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Actually, there is no downside in using a taggable cache pool as a backend for CacheInterface. This means we can simplify things and remove the TaggableCacheInterface and keep only CacheInterface (master-only). Commits ------- c250fbd [Cache] Remove TaggableCacheInterface, alias cache.app.taggable to CacheInterface
* 4.1: [DI] Remove default env type check on validate [FrameworkBundle][TwigBridge] Fix BC break from strong dependency on CSRF token storage
…ctController instances
…t (kbond) This PR was squashed before being merged into the 4.2-dev branch (closes symfony#27077). Discussion ---------- [DependencyInjection] add ServiceSubscriberTrait | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#23898 | License | MIT | Doc PR | symfony/symfony-docs#9809 This allows you to easily configure Service Subscribers with the following convention: ```php class MyService implements ServiceSubscriberInterface { use ServiceSubscriberTrait; public function doSomething() { // $this->router() ... } private function router(): RouterInterface { return $this->container->get(__METHOD__); } } ``` This also allows you to create helper traits like `RouterAware`, `LoggerAware` etc... and compose your services with them (*not* using `__METHOD__` in traits because it doesn't behave as expected.). ```php trait LoggerAware { private function logger(): LoggerInterface { return $this->container->get(__CLASS__.'::'.__FUNCTION__); } } ``` ```php trait RouterAware { private function router(): RouterInterface { return $this->container->get(__CLASS__.'::'.__FUNCTION__); } } ``` ```php class MyService implements ServiceSubscriberInterface { use ServiceSubscriberTrait, LoggerAware, RouterAware; public function doSomething() { // $this->router() ... // $this->logger() ... } } ``` Commits ------- 238e793 [DependencyInjection] add ServiceSubscriberTrait
…he container in AbstractController instances (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] Deprecate auto-injection of the container in AbstractController instances | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Should enhance DX by preventing situations like symfony#27436. Commits ------- e2f344f [FrameworkBundle] Deprecate auto-injection of the container in AbstractController instances
* 4.1: [Form] fix truncating form views in data collector [TwigBridge][Form] fix tests by moving AbstractBootstrap* cases to the bridge
* 4.1: fix merge bumped Symfony version to 4.1.3 [PhpUnitBridge] Describe weak_vendors properly [HttpKernel] Fix merging bindings for controllers' locators updated VERSION for 4.1.2 updated CHANGELOG for 4.1.2 bumped Symfony version to 4.0.14 updated VERSION for 4.0.13 updated CHANGELOG for 4.0.13 bumped Symfony version to 3.4.14 updated VERSION for 3.4.13 updated CHANGELOG for 3.4.13 bumped Symfony version to 2.8.44 Chaining senders with their aliases should work
* 4.1: Fix Clidumper tests Enable the fixer enforcing fully-qualified calls for compiler-optimized functions Apply fixers Disable the native_constant_invocation fixer until it can be scoped Update the list of excluded files for the CS fixer
* 4.1: Alpha-ordering for "use" statements
* 4.1: Fix tests for legacy phpunit versions Add missing Ukrainian translations Use an empty string as default for assertEquals
* 4.1: Enable native_constant_invocation CS fixer
* 4.1: Fix tests for legacy phpunit versions
This PR was merged into the 4.2-dev branch. Discussion ---------- link helper does not link Contracts | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT `link` is great tool in development and while working on another PR, noticed that all `symfony/*` packages are linked except `symfony/contracts` After this PR this issue will be fixed. Commits ------- 7c124c4 appending root of Contracts dir (where composer.json is located)
* 4.1: [HttpKernel] Fixed invalid REMOTE_ADDR in inline subrequest when configuring trusted proxy with subnet [FrameworkBundle] fixed guard event names for transitions [DI] Improve class named servics error message remove unnecessary instanceof in MongoDbSessionHandler [HttpFoundation] fixed using _method parameter with invalid type Renaming internal test class to help auto-completion [Intl] Replace svn with git in the icu data update script [Messenger] Fix error message on undefined message class for non-subscriber handler [HttpFoundation] Fix Cookie::isCleared
* 4.1: [HttpFoundation] Remove support for legacy and risky HTTP headers
* 4.1: [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
…jkl578) This PR was merged into the 4.2-dev branch. Discussion ---------- Remove direct dependencies on doctrine/common | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Resubmitting symfony#27609 now that Doctrine should be deprecation free. Commits ------- cb91cde Remove direct dependencies on doctrine/common
* 4.1: bumped Symfony version to 4.1.4 updated VERSION for 4.1.3 updated CHANGELOG for 4.1.3 [DoctrineBridge] allow dev versions of Doctrine again bumped Symfony version to 3.4.15 updated VERSION for 3.4.14 updated CHANGELOG for 3.4.14 bumped Symfony version to 2.8.45 updated VERSION for 2.8.44 update CONTRIBUTORS for 2.8.44 updated CHANGELOG for 2.8.44
I guess you have to rebase your PR... 😄 Also, bug fixes are supposed to target the lowest branch as possible, this bug has been introduced in 4.1 or it was already present before? |
@mul14 Can you fix this PR? |
New PR #28118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tiny thing.
Before
After