[Contracts] Add traits+interfaces from the DI component #28206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2701107 to
1cdc729
Compare
7fdf5c1 to
d4256fe
Compare
d4256fe to
675abdc
Compare
|
(rebased) |
fabpot
approved these changes
Sep 4, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 4, 2018
…t (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Contracts] Add traits+interfaces from the DI component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - * added `Service\ServiceSubscriberInterface` to declare the dependencies of a class that consumes a service locator * added `Service\ServiceSubscriberTrait` to implement `Service\ServiceSubscriberInterface` using methods' return types * added `Service\ServiceLocatorTrait` to help implement PSR-11 service locators Commits ------- 675abdc [Contracts] Add traits+interfaces from the DI component
fabpot
added a commit
that referenced
this pull request
Sep 5, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [DI] leverage Contracts\Service | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Embedding #28206 for now. This deprecates some generic interfaces from the DI component in favor of the similar ones proposed for `Contracts\Service`. Commits ------- 87392ab [DI] leverage Contracts\Service
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service\ServiceSubscriberInterfaceto declare the dependencies of a class that consumes a service locatorService\ServiceSubscriberTraitto implementService\ServiceSubscriberInterfaceusing methods' return typesService\ServiceLocatorTraitto help implement PSR-11 service locators