[DI] leverage Contracts\Service #28207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c427a5d to
422ce7f
Compare
stof
reviewed
Aug 16, 2018
| { | ||
| $this->factories = $factories; | ||
| use ServiceLocatorTrait { | ||
| get as doGet; |
There was a problem hiding this comment.
does this make doGet public or no ?
There was a problem hiding this comment.
nope, visibility changes must be explicit.
There was a problem hiding this comment.
ok, got it, fixed :)
e8a0a32 to
405b4e4
Compare
8294fc5 to
810890e
Compare
|
Should be rebased now |
810890e to
40cfe7a
Compare
fabpot
approved these changes
Sep 4, 2018
| @@ -19,6 +19,8 @@ | |||
| * not needed anymore. | |||
| * | |||
| * @author Christophe Coevoet <[email protected]> | |||
| * | |||
| * @deprecated since Symfony 4.2, use `ResetInterface` instead. | |||
There was a problem hiding this comment.
updated (and added to the CHANGELOG file)
40cfe7a to
87392ab
Compare
stof
approved these changes
Sep 5, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 5, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [DI] leverage Contracts\Service | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Embedding #28206 for now. This deprecates some generic interfaces from the DI component in favor of the similar ones proposed for `Contracts\Service`. Commits ------- 87392ab [DI] leverage Contracts\Service
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedding #28206 for now.
This deprecates some generic interfaces from the DI component in favor of the similar ones proposed for
Contracts\Service.