Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] Add new json Validator #28477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2019
Merged

[Validator] Add new json Validator #28477

merged 1 commit into from
Feb 13, 2019

Conversation

zairigimad
Copy link
Contributor

@zairigimad zairigimad commented Sep 15, 2018 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT
Doc PR symfony/symfony-docs#10351

Hi,

in so many cases we want to test if a value is a valid json or not, so I propose this new NotJson Json constraint for this need.

cordially,

@zairigimad zairigimad mentioned this pull request Sep 16, 2018
Closed
@chalasr chalasr added this to the next milestone Sep 16, 2018
@zairigimad zairigimad force-pushed the is-json-validator branch 3 times, most recently from c61fa99 to 24a15c2 Compare September 16, 2018 15:21
@zairigimad
Copy link
Contributor Author

Hi @onEXHovia , @apfelbox ,
I've just resolved @onEXHovia discussion and i can't see your discussion @apfelbox ,
Sorry i did an --amed.

@apfelbox
Copy link
Contributor

Look here: #28477 (comment)

Can you see it with this link?

@apfelbox
Copy link
Contributor

For the early exit, see:

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Constraints/BicValidator.php#L29-L31
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Constraints/CountryValidator.php#L35-L37
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Constraints/CurrencyValidator.php#L36-L38

(and the other validators)
You need this check, as your validator should only check something, if the value is not empty. Because currently you can't implement an optional field, that has to be valid JSON if it is filled. Currently it has to be filled and be valid JSON.

But for the "it has to be filled part" you should use NotBlank or NotNull. That's why your validator should bail if the field is just empty.

@zairigimad zairigimad force-pushed the is-json-validator branch 2 times, most recently from 0c13707 to b061fcf Compare September 17, 2018 18:18
@zairigimad zairigimad force-pushed the is-json-validator branch 3 times, most recently from 801f88e to 0ed8620 Compare September 18, 2018 18:35
ro0NL
ro0NL approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :) one last minor comment.

@zairigimad zairigimad force-pushed the is-json-validator branch 3 times, most recently from 5887556 to b8e7c7d Compare October 1, 2018 19:42
xabbuh
xabbuh approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve the conflict? Besides that this looks good to me.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Oct 3, 2018 •
edited
Loading

Sorry to come late here, but what's the purpose of a JSON validator?
This forces a double decoding of the JSON payload, since I suppose there will be another place that will have to get its decoded value. This other place will also expect some format for the decoded JSON, so that this should be the place where the validation should happen really. Did I miss something?

@ro0NL
Copy link
Contributor

ro0NL commented Oct 4, 2018 •
edited
Loading

I've at least added this once in a project, to validate (for the backend) arbitrary JSON sent by DraftJS. No decoding, just accepting json strings.

@zairigimad
Copy link
Contributor Author

Hi, we used to validate a lot of normal string inputs filled by contributors to see if valid JSON or not before saving them to the database. ( Application that provides configs as JSON used by other applications ). I'm not sure if it was the best way to provide configs but it was something like Cloudformation.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/images/designer-jsoneditor.png

@nicolas-grekas nicolas-grekas changed the title Add new json Validator [Validator] Add new json Validator Jan 27, 2019
chalasr
chalasr approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs rebase

@zairigimad
Copy link
Contributor Author

@chalasr rebase done :)

javiereguiluz
javiereguiluz approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor comment, but I like this. Thanks @zairigimad.

fabpot
fabpot approved these changes Feb 13, 2019
View reviewed changes
src/Symfony/Component/Validator/Resources/translations/validators.en.xlf
@@ -330,6 +330,10 @@
<source>This Business Identifier Code (BIC) is not associated with IBAN {{ iban }}.</source>
<target>This Business Identifier Code (BIC) is not associated with IBAN {{ iban }}.</target>
</trans-unit>
<trans-unit id="85">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 86.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see 21b8efc

@fabpot
Copy link
Member

fabpot commented Feb 13, 2019

Thank you @zairigimad.

@fabpot fabpot merged commit 131febc into symfony:master Feb 13, 2019
fabpot added a commit that referenced this pull request Feb 13, 2019
@fabpot
feature #28477 [Validator] Add new json Validator (zairigimad)
b951a0f 
This PR was squashed before being merged into the 4.3-dev branch (closes #28477).

Discussion
----------

[Validator] Add new json Validator

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT
| Doc PR        | symfony/symfony-docs#10351

Hi,

in so many cases we want to test if a value is a valid json or not, so I propose this new ~~NotJson~~  `Json` constraint for this need.

cordially,

Commits
-------

131febc [Validator] Add new json Validator
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Mar 4, 2019
@javiereguiluz
minor #10351 [Validator] Add new json Validator Documentation (zairig…
791a412 
…imad)

This PR was squashed before being merged into the master branch (closes #10351).

Discussion
----------

[Validator] Add new json Validator Documentation

Hi,

introduce ~~IsJson~~ `Json` Constraint .
this is a documentation for the new feature in the pull request symfony/symfony#28477

cordially,

Commits
-------

01ea746 [Validator] Add new json Validator Documentation
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Merged
DavidPrevot added a commit to DavidPrevot/symfony that referenced this pull request May 13, 2019
@DavidPrevot
Drop useless executable bit
7905863 
The files were added as executable via symfony#28477.
@DavidPrevot DavidPrevot mentioned this pull request May 13, 2019
Merged
fabpot added a commit that referenced this pull request May 13, 2019
@fabpot
minor #31488 Drop useless executable bit (DavidPrevot)
1bce54c 
This PR was merged into the 4.3 branch.

Discussion
----------

Drop useless executable bit

The files were added as executable via #28477.

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

7905863 Drop useless executable bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onEXHovia onEXHovia onEXHovia left review comments

@stof stof stof left review comments

@jsamouh jsamouh jsamouh left review comments

@jvasseur jvasseur jvasseur left review comments

@apfelbox apfelbox apfelbox left review comments

@linaori linaori linaori requested changes

@fabpot fabpot fabpot approved these changes

@maidmaid maidmaid maidmaid left review comments

@gmponos gmponos gmponos left review comments

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@ro0NL ro0NL ro0NL approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed Validator
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.