[WebServerBundle] Added ability to display the current hostname address if available when binding to 0.0.0.0 #28586
Conversation
| /** | ||
| * @return string contains resolved hostname if available, empty string otherwise | ||
| */ | ||
| public function getExtraAddress() |
There was a problem hiding this comment.
What about renaming this method as getRealAddress() or getResolvedAddress() ?
There was a problem hiding this comment.
@javiereguiluz will do, it reads better.
| $io->success(sprintf('Server listening on http://%s', $config->getAddress())); | ||
| $message = sprintf('Server listening on http://%s', $config->getAddress()); | ||
| if ('' !== $extra = $config->getExtraAddress()) { | ||
| $message = sprintf('%s (http://%s)', $message, $extra); |
There was a problem hiding this comment.
Not sure if we can hardcode http:// here. What if we are using https:// in the local environment? Maybe it's better to detect that and add it in the getExtraAddress() method.
There was a problem hiding this comment.
@javiereguiluz we assume this as the php server won't support SSL, besides we already assume this in the original message.
| $io->success(sprintf('Server listening on http://%s', $config->getAddress())); | ||
| $message = sprintf('Server listening on http://%s', $config->getAddress()); | ||
| if ('' !== $extra = $config->getExtraAddress()) { | ||
| $message = sprintf('%s (http://%s)', $message, $extra); |
There was a problem hiding this comment.
To make it a bit easier to understand for users, we could change the output from this:
[OK] Server listening on http://0.0.0.0:8080 (http://172.20.0.2:8080)
to something like this:
[OK] Server listening on http://0.0.0.0:8080 (resolved as http://172.20.0.2:8080)
There was a problem hiding this comment.
@javiereguiluz will do the change as resolved, this should also match the method name change (more consistent)
88b2ad2 to
6417342
Compare
| /** | ||
| * @return string contains resolved hostname if available, empty string otherwise | ||
| */ | ||
| public function getResolvedAddress() |
There was a problem hiding this comment.
I'd suggest calling it getDisplayAddress actually (nothing is "resolved" to me)
There was a problem hiding this comment.
Do you recommend to reword the message displayed to users too? Currently it says ... (resolved as ...) I think it's easy to understand that way ... but may there's a better wording. Thanks!
There was a problem hiding this comment.
We already have a suggestion in the issue
[OK] Server listening on all interfaces, port 8080 -- see http://127.0.0.1:8080
…ss if available when binding to 0.0.0.0
6417342 to
dfd2e8b
Compare
|
Updated with the new messages, thanks to @jkufner suggestion, I believe the message now looks cleaner and conveys what we want. |
|
Thank you @respinoza. |
… hostname address if available when binding to 0.0.0.0 (respinoza) This PR was merged into the 4.2-dev branch. Discussion ---------- [WebServerBundle] Added ability to display the current hostname address if available when binding to 0.0.0.0 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | ? (no tests for server commands) | Fixed tickets | #28585 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Tries to get the local hostname into an ip (if available) using the PHP gethostname* methods. Commits ------- dfd2e8b [WebServerBundle] Added ability to display the current hostname address if available when binding to 0.0.0.0
Tries to get the local hostname into an ip (if available) using the PHP gethostname* methods.