[Workflow] [WIP] #28874 add style to workflow dumps#28933
Closed
alexislefebvre wants to merge 1 commit into
Closed
[Workflow] [WIP] #28874 add style to workflow dumps#28933alexislefebvre wants to merge 1 commit into
alexislefebvre wants to merge 1 commit into
Conversation
Member
|
Hello, Thanks for this PR. As we are not clear about the configuration (see your issue #28874) |
fabpot
added a commit
that referenced
this pull request
Mar 19, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #29538). Discussion ---------- [Workflow] Add colors to workflow dumps Fixes #28874 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28874, replaces #28933 | License | MIT | Doc PR | TODO, requires symfony/symfony-docs#9476 Fetch data with the `MetadataStore` from #26092 in order to add colors to the dumps. Example of configuration: ```yaml transitions: submit: from: start to: travis metadata: title: transition submit title dump_style: label: 'My custom label' arrow_color: '#0088FF' label_color: 'Red' ``` This code was developed as a bundle, examples can be found on its repository: https://github.com/alexislefebvre/SymfonyWorkflowStyleBundle Commits ------- 60ad109 [Workflow] Add colors to workflow dumps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch data from MetadataStore #26092 in order to add colors to the dumps.
This is a proof of concept to show that it's possible to define the color of a
Transition, but I need some help to define the best way to provide a simple and powerful way to configure the outputs of the workflow dumps. Please add your thoughts about this.I started a discussion about the different options here: #28874 (comment)
Background
Here is how we can define the colors of a transition, a
Redarrow and aBluelabel :So we have to inject some data in the PUML file.
Default output and output with this PR:
(the
t2transition is blue and thet1transition is red)